music-assistant / hass-music-assistant

Turn your Home Assistant instance into a jukebox, hassle free streaming of your favorite media to Home Assistant media players.
Apache License 2.0
1.31k stars 48 forks source link

"got an unexpected keyword argument 'pcm_format'" when trying to announce on speaker #2067

Closed ministryofsillywalks closed 5 months ago

ministryofsillywalks commented 5 months ago

What version of Music Assistant has the issue?

2.0.0b124

What version of the Home Assistant Integration have you got installed?

2024.3.2

Have you tried everything in the Troubleshooting FAQ and reviewed the Open and Closed Issues and Discussions to resolve this yourself?

The problem

When trying to use the new feature to anounce via tts.speak the announcement never gets read.

How to reproduce

Have an Airplay speaker connected to Music Assistant (works for music) Try to call a tts.speak service on the Airplay speaker.

Music Providers

tts.speak

Player Providers

Airplay

Full log output

2024-03-26 20:38:15.691 INFO (MainThread) [music_assistant.players] Playback announcement to player MA Esstisch AP (with pre-announce: True): http://10.10.10.2:8123/api/tts_proxy/8cf62703646ebf23c58be2ab94d35857b1df0bcf_da-dk_-_tts.piper.mp3
2024-03-26 20:38:18.150 ERROR (MainThread) [music_assistant.webserver] Error handling message: players/cmd/play_announcement: StreamsController.get_announcement_stream() got an unexpected keyword argument 'pcm_format'
2024-03-26 20:41:53.364 INFO (MainThread) [music_assistant.players] Playback announcement to player MA Esstisch AP (with pre-announce: True): http://10.10.10.2:8123/api/tts_proxy/8cf62703646ebf23c58be2ab94d35857b1df0bcf_da-dk_-_tts.piper.mp3
2024-03-26 20:41:53.365 ERROR (MainThread) [music_assistant.webserver] Error handling message: players/cmd/play_announcement: StreamsController.get_announcement_stream() got an unexpected keyword argument 'pcm_format'
2024-03-26 20:45:21.140 INFO (MainThread) [music_assistant.players] Playback announcement to player MA Esstisch AP (with pre-announce: True): http://10.10.10.2:8123/api/tts_proxy/8cf62703646ebf23c58be2ab94d35857b1df0bcf_da-dk_-_tts.piper.mp3
2024-03-26 20:45:21.141 ERROR (MainThread) [music_assistant.webserver] Error handling message: players/cmd/play_announcement: StreamsController.get_announcement_stream() got an unexpected keyword argument 'pcm_format'
2024-03-26 20:45:50.947 INFO (MainThread) [music_assistant.streams] Start Queue Flow stream for Queue MA Esstisch AP - crossfade: False
2024-03-26 20:46:20.474 INFO (MainThread) [music_assistant.players] Playback announcement to player MA Esstisch AP (with pre-announce: True): http://10.10.10.2:8123/api/tts_proxy/8cf62703646ebf23c58be2ab94d35857b1df0bcf_da-dk_-_tts.piper.mp3
2024-03-26 20:46:22.644 ERROR (MainThread) [music_assistant.webserver] Error handling message: players/cmd/play_announcement: StreamsController.get_announcement_stream() got an unexpected keyword argument 'pcm_format'
2024-03-26 20:47:08.793 INFO (MainThread) [music_assistant.streams] Start Queue Flow stream for Queue MA Esstisch AP - crossfade: False

Additional information

The mp3 of the announcement plays perfectly fine when copying the url from the log.

What version of Home Assistant Core are your running

2024.3.2

What type of installation are you running?

Home Assistant OS

On what type of hardware are you running?

Generic x86-64 (e.g. Intel NUC)

marcelveldt commented 5 months ago

fixed in b125

ministryofsillywalks commented 5 months ago

Working with latest update! Thanks for the quick fix.