music-assistant / hass-music-assistant

Turn your Home Assistant instance into a jukebox, hassle free streaming of your favorite media to Home Assistant media players.
Apache License 2.0
1.2k stars 44 forks source link

Tune-In plugin adding multiple streams for certain radio stations which fail to work, while single stream stations do work #2386

Open ufankhau opened 1 month ago

ufankhau commented 1 month ago

What version of Music Assistant has the issue?

2.1.0b1

What version of the Home Assistant Integration have you got installed?

No response

Have you tried everything in the Troubleshooting FAQ and reviewed the Open and Closed Issues and Discussions to resolve this yourself?

The problem

Tune-In provides for some radio stations (e.g. Radio Swiss Classic or Radio Swiss Pop) several streams. Such entries do not work, while stations with a single stream do work correctly. Image Image 29 05 2024 at 10 54

How to reproduce

select in your tune-in account Radio Swiss Classic

Music Providers

tune-in

Player Providers

Airplay

Full log output

No response

Additional information

No response

What version of Home Assistant Core are your running

2024.4.4

What type of installation are you running?

Home Assistant OS

On what type of hardware are you running?

Raspberry Pi

marcelveldt commented 1 month ago

Do not try to fill in the conclusion yourself. The problem is that Radio Swiss is not working on Tune-In. If that has anything to do with the fact that multiple streams are offered is to be seen later.

ufankhau commented 1 month ago

I politely disagree with your reply, Marcel. Radio Swiss Classic (shown radio station on the screen shot) does perfectly work on Tune-In, Radio Swiss might not exit and might hence not work.

marcelveldt commented 2 weeks ago

Investigated the issue, like I suspected it had nothing to do with the fact that there were multiple streams in the radio station. In fact it was a codec detection issue which I just fixed. Next update (2.0.7 or 2.1.0b6) contains this fix.

OzGav commented 1 week ago

@ufankhau Please confirm this has been fixed.

ufankhau commented 1 week ago

Thx Marcel for fixing the issue with no stream being picked up when several streams are offered by Tune-In Radio for a specific radio station. It is still unclear to me, which stream music-assistant does pick up by default (acc or mp3), when several streams are available. The UI does furthermore not always show the "type" of stream (see ? in screen shot attached). I have so far not identified a pattern of when the type is shown correctly and when a "?" is showing up. Last but not least music-assistant shows sometimes 2 streams in the "Queue" section (see attached screen prints), even for a radio station with a single stream offered by Tune-In Radio (e.g. Radio Beach Westkust).

So, overall a great step in the right direction with some glitches remaining to be fixed (e.g. "?" in UI and double entry in Queue)

Image 16 06 2024 at 10 44 Image 16 06 2024 at 10 44

PS: I like very much the changes brought to the volume bar with the - and + buttons .... for the time being the default step change seems to be +/- 5% .... could this value be defined by the user in future? I personally prefer +/- 2% changes in volume ....

OzGav commented 1 week ago

On the second image that just looks like you have added it twice

ufankhau commented 1 week ago

Sorry, but I did not add it twice .... I have repeated the steps and cleared the queue ...

Image 16 06 2024 at 14 27

.. selected the desired radio station and started it with "Play Now (clear queue)"

Image 16 06 2024 at 14 31

... the stream starts correctly, the queue shows 1, but in fact it lists two items .....

Image 16 06 2024 at 14 32

... sorry for being such a pain .....