search

music-assistant / hass-music-assistant

Turn your Home Assistant instance into a jukebox, hassle free streaming of your favorite media to Home Assistant media players.
Apache License 2.0
1.39k stars 51 forks source link

Skipping tracks in quick succession causes multiple streams to be sent to media player. #2612

Closed brian-maher closed 3 months ago

brian-maher commented 4 months ago

What version of Music Assistant has the issue?

2.1.0b11

What version of the Home Assistant Integration have you got installed?

2024.5.1

Have you tried everything in the Troubleshooting FAQ and reviewed the Open and Closed Issues and Discussions to resolve this yourself?

The problem

When playing music using the Spotify provider, skipping multiple times in quick succession (before the next song is playing) will cause multiple streams to be sent to the player simultaneously. These multiple streams persist until MASS is restarted.

How to reproduce

This is easily reproducible on my setup:

  1. Play a Spotify playlist
  2. Mash the "Next Track" button 3/4 times
  3. There will be a short delay before multiple streams are sent to the player (using Airplay this manifests itself as 2 songs alternating every few seconds).

Music Providers

Spotify

Player Providers

Airplay

Full log output

mass.log

Additional information

Whilst mashing the next button may seem rather obtuse, it's standard user behavior to skip a multiple tracks, and in my case it was triggered accidentally.

What version of Home Assistant Core are your running

2024.5.4

What type of installation are you running?

Home Assistant Container

On what type of hardware are you running?

Generic x86-64 (e.g. Intel NUC)

github-actions[bot] commented 3 months ago

This issue is stale because it has been open 14 days with no activity. Comment or this will be closed in 7 days.

marcelveldt commented 3 months ago

This issue should be fixed in 2.1.0

OzGav commented 3 months ago

@brian-maher please update to 2.1.0 and confirm if this has been fixed

brian-maher commented 3 months ago

Thanks - have just tested and the behavior has changed, but it's still occurring. Now, instead of enqueuing 2 tracks, it's enqueuing every song that's skipped over in quick succession.

I'll try do to some more digging.

OzGav commented 3 months ago

Any chance of a video to show what you mean?

OzGav commented 3 months ago

@brian-maher This should be fixed in 2.1.3 or 2.2.0b5 please confirm

OzGav commented 3 months ago

Closing assumed fixed