music-assistant / hass-music-assistant

Turn your Home Assistant instance into a jukebox, hassle free streaming of your favorite media to Home Assistant media players.
Apache License 2.0
1.3k stars 47 forks source link

Change timzeone for Squeezebox Radio #2633

Open SvenSchiffner opened 1 month ago

SvenSchiffner commented 1 month ago

What version of Music Assistant has the issue?

2.0.7

What version of the Home Assistant Integration have you got installed?

2024.7.1.b0

Have you tried everything in the Troubleshooting FAQ and reviewed the Open and Closed Issues and Discussions to resolve this yourself?

The problem

Hello, thank you for the great software. I used the LMS previously and switched to Music Assistant yesterday. It works great, but I found an issue. I'm living in Germany. So the correct timezone is UTC+2 in the summer. But my Squeezebox Radio showing the UTC time. I found no options to set the timezone in MASS. In HA I set the correct timezone. I also looked in the source code. But I'm unfamiliar with slimproto and found no real hint, how the time is sent. Also in the menu of the Squeezebox Radios I found no option.

How to reproduce

Use a Squeezebox Radio in another timezone.

Music Providers

Independent

Player Providers

Slimproto

Full log output

No response

Additional information

No response

What version of Home Assistant Core are your running

2024.7.2

What type of installation are you running?

Home Assistant OS

On what type of hardware are you running?

Generic x86-64 (e.g. Intel NUC)

OzGav commented 1 month ago

Did the time show correctly with LMS (or not show at all?)

SvenSchiffner commented 1 month ago

It showed correctly. But in the LMS you also had an option to set the language and the timezone. The MASS integration is also using my language settings from HA correctly and is displayed in German.

SvenSchiffner commented 1 month ago

I found to interesting function in the aioslimproto source code. This should be for older players like the boom, which gets the display data over slimproto and this should be the relevant function for newer players, which use the CLI. Their is no custom timezone. So in my opinion the timezone of the system is used. In the code for the HA add-on I found no hint for a custom timezone or the TZ environment variable. So maybe, the never player never got the correct local time.

cociweb commented 1 month ago

Are the timestamps OK in the downloadable log file? (Settings>Core)

SvenSchiffner commented 1 month ago

Good point, the timestamps in the logs are in my local time and not UTC.

github-actions[bot] commented 3 weeks ago

This issue is stale because it has been open 21 days with no activity. Comment or this will be closed in 7 days.

github-actions[bot] commented 1 week ago

This issue is stale because it has been open 21 days with no activity. Comment or this will be closed in 7 days.

marcelveldt commented 1 week ago

Not stale