music-assistant / hass-music-assistant

Turn your Home Assistant instance into a jukebox, hassle free streaming of your favorite media to Home Assistant media players.
Apache License 2.0
1.39k stars 51 forks source link

TIDAL - HI_RES - NOT Working // quality has unexpected type: <class 'str'>, fallback to default #2642

Closed ghost closed 3 months ago

ghost commented 4 months ago

What version of Music Assistant has the issue?

2024.7

What version of the Home Assistant Integration have you got installed?

2024.7

Have you tried everything in the Troubleshooting FAQ and reviewed the Open and Closed Issues and Discussions to resolve this yourself?

The problem

TIDAL HI_RES --> NOT Working

quality has unexpected type: <class 'str'>, fallback to default


2024-07-17 20:54:55.700 WARNING (MainThread) [music_assistant.common.models.config_entries] quality has unexpected type: <class 'str'>, fallback to default 2024-07-17 20:55:31.127 INFO (MainThread) [music_assistant] Loaded plugin provider Home Assistant 2024-07-17 20:55:46.341 WARNING (MainThread) [music_assistant.common.models.config_entries] quality has unexpected type: <class 'str'>, fallback to default 2024-07-17 20:55:49.373 WARNING (MainThread) [music_assistant.common.models.config_entries] quality has unexpected type: <class 'str'>, fallback to default 2024-07-17 20:57:48.949 WARNING (MainThread) [music_assistant.common.models.config_entries] quality has unexpected type: <class 'str'>, fallback to default 2024-07-17 20:57:56.445 WARNING (MainThread) [music_assistant.common.models.config_entries] quality has unexpected type: <class 'str'>, fallback to default 2024-07-17 20:58:03.226 WARNING (MainThread) [music_assistant.common.models.config_entries] quality has unexpected type: <class 'str'>, fallback to default 2024-07-17 20:58:08.292 INFO (MainThread) [music_assistant] Loaded music provider Tidal 2024-07-17 20:58:09.093 INFO (MainThread) [music_assistant.music] Sync task for Tidal completed 2024-07-17 20:58:10.266 INFO (MainThread) [music_assistant.music] Sync task for Tidal completed 2024-07-17 20:58:21.726 WARNING (MainThread) [music_assistant.common.models.config_entries] quality has unexpected type: <class 'str'>, fallback to default 2024-07-17 20:58:22.068 INFO (MainThread) [music_assistant] Loaded music provider Tidal 2024-07-17 20:58:22.798 INFO (MainThread) [music_assistant.music] Sync task for Tidal completed

How to reproduce

Change to HI_RES

Music Providers

Tidal

Player Providers

Tidal

Full log output

No response

Additional information

No response

What version of Home Assistant Core are your running

2024.7.2

What type of installation are you running?

Home Assistant OS

On what type of hardware are you running?

Generic x86-64 (e.g. Intel NUC)

OzGav commented 4 months ago

Confirmed. I see it on the DEV version of the addon with anything other than LOSSLESS

jozefKruszynski commented 4 months ago

I think I might have a fix, what I realize though is that with the current implementation I have, I don't think that it's actually possible to change quality after adding the provider. I'll have to look into this, I guess I never tested it as I assumed that once added nobofmdy would ever try to change quality.

jozefKruszynski commented 4 months ago

Also. This currently only happens for me when trying to change after already setting up once. So I can select any quality and save the first time. But if I then try to reconfigure, that is when I get the issue.

Can you confirm that this is also the behaviour you see? @OzGav @TSK7M

OzGav commented 4 months ago

Yes that would be correct I expect as I set it up on my test server then tried to change it

ghost commented 4 months ago

@jozefKruszynski I can't confirm that, I've redone the setup several times and the poor music quality (No HI_RES) keeps returning, even with a new connection.


New connection with TIDAL

image

After reopening it says "LOSSLESS" again The music only plays at 44.1/16.

image
OzGav commented 4 months ago

Do also note the weird font in the selection box. Not sure what that is about?

jozefKruszynski commented 4 months ago

Also saw this weird text. No idea when and how that happened.

OzGav commented 4 months ago

This will be fixed in a beta for MA 2.2 in the future. It will be a breaking change as the whole login process has been redesigned.

ghost commented 3 months ago

It works again!! Thank you! greeting