music-assistant / hass-music-assistant

Turn your Home Assistant instance into a jukebox, hassle free streaming of your favorite media to Home Assistant media players.
Apache License 2.0
1.32k stars 49 forks source link

Some tracks are marked with the wrong artist / artwork after 2.2 upgrade #2792

Closed madbrain76 closed 1 month ago

madbrain76 commented 1 month ago

What version of Music Assistant has the issue?

2.2.1

What version of the Home Assistant Integration have you got installed?

2024.8.1

Have you tried everything in the Troubleshooting FAQ and reviewed the Open and Closed Issues and Discussions to resolve this yourself?

The problem

After upgrading to 2.2.1, several Qobuz tracks from Jean-Michel Jarre are showing as being from Andreas Staier. The lone file system provider track I have, a WAV file with zero metadata in it, also shows as being from Andreas Staier.

How to reproduce

  1. Install MA 2.2.1
  2. In the Qobuz app, favorite 4 tracks from the "Planet Jarre" album from Jean-Michel Jarre, and other Jarre albums
  3. Add Qobuz provider to MA
  4. Create a playlist that includes the 4 tracks from step 2, and also other tracks from Jarre albums, which are not favorited
  5. Review the playlist content . It shows this.

image

As you can see, tracks 1, 3, 4, and 5 are all shown as being authored by Andreas Staier. / Jean-Michel Jarre . That would be an unusual collaboration to be sure ! The tracks are actually all from Jean-Michel Jarre. The album artwork shown is the correct one, though.

This was not the case in 2.1.x .

  1. Add the file system (remote) provider, pointing it to a directory containing a single chants.wav file that has no metadata
  2. Go to the track view in MA
  3. Looks for the file called "chants" which is the name of the WAV file in my FS provider with no meta data
  4. This is what appears :

image

It is also shown as being authored by Andreas Staier, and it has a picture of Andreas Staier in the artwork as well.

There should be no artwork and no artist name, since there is no metadata for this WAV file.

This was also behaving correctly in 2.1.x .

Music Providers

Qobuz File system (remote)

Player Providers

N/A

Full log output

ma.log

Additional information

I can reproduce this issue at will by rolling back to 2.1.x from an add-on backup in HA . Upgrading again to 2.2.x shows the regression.

What version of Home Assistant Core are your running

2024.8.2

What type of installation are you running?

Home Assistant OS

On what type of hardware are you running?

Windows

madbrain76 commented 1 month ago

Here is what the playlist looks like after rolling back to 2.1.4 from backup .

image

And here is what the WAV file looks like in 2.1.4 :

image

Both are correct.

marcelveldt commented 1 month ago

Please let me know exactly which of these files exist on your local disk and in what structure they're in.

madbrain76 commented 1 month ago

There is only a single WAV file in my FS (remote) provider directory.

image

This WAV file was created by me in Powerdirector. It has no metadata, and does not exist in Qobuz.

Here is the configuration for the file system (remote) provider.

image

Every other track comes from Qobuz.

I'm not aware of any other local files. I have not tried to inspect the files in MA itself on the HAOS VM.

madbrain76 commented 1 month ago
  1. BTW, even after deleting the "file system (remote)" music provider completely, the problem from steps 1-5 remains.

The main reason I reported the issue with both the Qobuz and FS (remote) providers together is that they are listing the same wrong artist, Andreas Staier, on tracks from each music provider.

  1. I deleted the Qobuz provider also, as a test
  2. I added the FS (remote) music provider again . The lone WAV showed up correctly, with no artist or artwork
  3. I added the Qobuz music provider again. The problem with the wrong artist also went away

So, this seems to be an upgrade issue. But at least there is a workaround.

OzGav commented 1 month ago

2.2.2 has been released which does fix a bug with provider removal. I wonder if you have been affected by that?

OzGav commented 1 month ago

Where does Andreas Staier come from. Do you have him in the library also?

madbrain76 commented 1 month ago

2.2.2 has been released which does fix a bug with provider removal. I wonder if you have been affected by that?

I'm still on 2.2.1 . It seems I'm getting upgrade notifications on time delay. Do you have a reference to the bug in question ?

I believe I was indeed affected by an issue with provider removal. MA showed a "spinning" icon. I worked around it by restarting the add-on. I did not want to pollute this bug with this issue, which I believe is unrelated.

The problem as I described it in the original post did not involve provider removal. I started with both Qobuz and FS providers in 2.1.4 . I then upgraded to 2.2, and saw the reported problem. No provider removal was involved to see the issue. I can still rollback to 2.1.4, upgrade again, and reproduce.

madbrain76 commented 1 month ago

Where does Andreas Staier come from. Do you have him in the library also?

Yes. I have him favorited in Qobuz. And that translates to him showing up in the MA library under artists.

marcelveldt commented 1 month ago

Super strange, I'm trying to reproduce it but so far without luck. I have favorited the same tracks and artists in Qobuz. Make me wonder if it has somehow to do with that tag-less file.

madbrain76 commented 1 month ago

If there is a way to remove my Qobuz and FS credentials, I'm happy to give you a backup of my add-on.

I can also try restoring a backup from a few days ago when I did not have the FS provider at all, only Qobuz, and then do the migration again.

marcelveldt commented 1 month ago

If there is a way to remove my Qobuz and FS credentials, I'm happy to give you a backup of my add-on.

Well basically I only need to investigate the library and cache db's, which contain no credentials at all. So if you unzip the backup, you should be able to extract the two .db files from there and send me with discord PM ?

madbrain76 commented 1 month ago

@marcelveldt check your PM . I'm madbrain there (once in a while, anyway).

dmcc commented 1 month ago

In case it's useful: I'm also seeing something like this (unusual "collaborations" on songs 😁 ) and I'm not using Qobuz.

My setup is just Chromecast + Filesystem (local).

sfnis commented 1 month ago

I have Plex as my only provider, and its happening to me too. It was fine in the previous version, its not affecting functionally, but its sort of funny.

MH - MAD

mh-2

PearlJam

bj61251 commented 1 month ago

I'm also seeing this issue, where albums are being attributed to two completely unrelated artists. Currently loading plex, and local file system as sources (they're virtually the same thing in my case).

Screenshot_20240824-092251

bj61251 commented 1 month ago

So a bit more info, in my case all of the problematic albums seemed to be coming from the local file system provider. I just deleted that music provider, and all of the bad tracks disappeared. Not sure if that'll help others or not, but I figured it's worth mentioning.

dutchmendesign commented 1 month ago

Same here! Upgrade 2.2.1 to 2.2.2 It was a mess so i reinitialize DB. After new scan some artist names are still messed up and for some also metadata artist.jpg is swapped with cover.jpg. Music provider: Remote share

2024-08-24 10:13:42.822 ERROR (MainThread) [music_assistant.webserver] Error handling message: music/refresh_item: artist not found in library: 189

Will try a fresh reinstall now....

dutchmendesign commented 1 month ago

It looks like there is something getting messed up particularly when artist = album. In my case: Artist 'Bloc Party' with album 'Bloc Party'. Franz Ferdinand - Franz Ferdinand The Doors -The Doors Weezer - Weezer

Schermafbeelding 2024-08-24 205049

Schermafbeelding 2024-08-24 205135

Schermafbeelding 2024-08-24 205206

OzGav commented 1 month ago

@dutchmendesign yes Marcel has identified this issue and will fix it soon https://discord.com/channels/753947050995089438/1098863590926204949/1276822113029984278

OzGav commented 1 month ago

The artwork issue when artist name = album name should be fixed in 2.3.0 beta 4

marcelveldt commented 1 month ago

this one should be entirely fixed with 2.3.0b8 although I cant repair any already mangled entries - either restore a backup first and then upgrade to 2.3.0b8 or initiate a full library scan (or just refresh the wrong items manually)

Only issue left is a small glicth in the album tracks listings where the wrong album is shows but this is just a UI glitch that will be fixed in the next beta.

w00master commented 1 month ago

Hi everyone. I'm on 2.3.0b8, but unfortunately I'm still seeing this issue:

image

I've not done anything with my tagging, so this has been a completely new issue for me. I'm also checking in Plex, and in there all of the artists/albums are structured correctly.

I see @marcelveldt mentioning a "Full library scan" how does one do this? Is this Synchronize or Reload? I've done both and nothing has changed.

Edit: I saw earlier a question on how files are structured. My music files are structured in a simple manner:

Artist (Folder) - Albums (Folder within Artist) - Song (list of songs in track order of Album)

Tag example (Van Halen - 1984): image

OzGav commented 1 month ago

@w00master make sure your share is mapped to the Music level of that drive.

A full db reset is achieved by going to MA SETTINGS>>CORE>>MUSIC CONTROLLER>> ADVANCED but hold off on that until after the next beta as some more fixes have been made.

w00master commented 1 month ago

Thanks @OzGav. That said, what do you mean re: "make sure your share is mapped to the Music level of that drive."

Are you referring to Plex library being Mapped to D:\daapd\Music instead of D:\daapd\Music\Van Halen\ ?

or are you saying the \Music directory needs to be in the root directory of the drive?

if it's the former, I"m all set. Just wanted to be sure I understood. Re: full reset - thank you. I'll hold off until the update comes.

OzGav commented 1 month ago

@w00master I didn’t know you were using Plex. So disregard in that case. However, unless there is a specific reason we recommend you skip the middleman and use the local provider in which case you should map that provider to d://daapd/Music

w00master commented 1 month ago

Thanks @OzGav I've disabled Plex Music and enabled Filesystem (remote share). I'm still unfortunately seeing the same issue - but will wait for the next update to see if this fixes it. If not will try the full reload.

madbrain76 commented 1 month ago

@w00master Did you try removing the music provider and adding it back ? That had solved it for me earlier when I ran into the issue.

OzGav commented 1 month ago

@w00master please try with beta 16

w00master commented 1 month ago

Thanks @OzGav and everyone. Before updating to beta 16 - (did this yesterday) - I removed the Plex provider (instead of just disabling it) and just entirely went only with Filesystem (remote) and it appears that has fixed the issue. Unsure what Plex did or MA's provider of Plex did, but removing it entirely got the tagging back in order.

Currently updating to beta 16. Thanks everyone.

jpbaril commented 2 weeks ago

@OzGav This does not seem to be resolved, I still have the issue.

Since around beginning of August metadata constantly get mixed up. I have reset the database 3 times since then and the issue always reappear. At first it was almost all my library that was incorrect, but in the last few versions it happens here and there for a few albums and tracks. Last time I did reset was yesterday and I again have wrong metadata shown. I was/am on server version 2.2.5 with HA integration 2024.9.1. Music provider is a remote share.

Capture d’écran du 2024-09-17 15-57-34 As you can see, the correct artist should be "Ska-P", yet it is shown as "Crosby, Stills, Nash & Young".

OzGav commented 2 weeks ago

@jpbaril how have you tagged your music?

jpbaril commented 2 weeks ago

@jpbaril how have you tagged your music?

Usually either with Picard or Synology Audio Station. But in example above I don't remember. In all cases, it looks ok when browsing in Synology Audio Station.

OzGav commented 2 weeks ago

It doesnt really matter what it looks like elsewhere. The track naming suggests to me that it isnt tagged correctly. Please post a screen capture of all the tags from Picard of the second track

jpbaril commented 2 weeks ago

Well, I retagged the whole artist folder in the meantime so it would not be truthful anymore for this issue.

OzGav commented 2 weeks ago

Then you should remove both artists ska-p and CSNY so these albums also get removed and then resync