music-assistant / hass-music-assistant

Turn your Home Assistant instance into a jukebox, hassle free streaming of your favorite media to Home Assistant media players.
Apache License 2.0
1.4k stars 51 forks source link

Mute status not correct for Airplay clietns #2866

Closed maxi1134 closed 2 months ago

maxi1134 commented 2 months ago

What version of Music Assistant has the issue?

2.3.0b17

What version of the Home Assistant Integration have you got installed?

2024.8.1

Have you tried everything in the Troubleshooting FAQ and reviewed the Open and Closed Issues and Discussions to resolve this yourself?

The problem

Active unmuted speakers report their volume as "muted" while they are outputting sound at the set volume.

image

How to reproduce

Start music Mute a speaker Raise it's volume

Music Providers

Spotify SMB

Player Providers

Airplay

Full log output

2024-09-01 16:53:08.441 INFO (MainThread) [music_assistant.players] Player Hallway Wiim does not support muting, using volume instead
2024-09-01 16:53:08.441 DEBUG (MainThread) [music_assistant.players] Handling command cmd_volume_set for player Hallway Wiim
2024-09-01 16:53:08.457 DEBUG (MainThread) [music_assistant.webserver] Handling command players/cmd/volume_set
2024-09-01 16:53:08.458 DEBUG (MainThread) [music_assistant.players] Handling command cmd_volume_set for player livingroom wiim
2024-09-01 16:53:08.687 DEBUG (MainThread) [music_assistant.webserver] Handling command players/cmd/volume_mute
2024-09-01 16:53:08.687 DEBUG (MainThread) [music_assistant.players] Handling command cmd_volume_mute for player kitchen wiim
2024-09-01 16:53:08.687 INFO (MainThread) [music_assistant.players] Player kitchen wiim does not support muting, using volume instead
2024-09-01 16:53:08.687 DEBUG (MainThread) [music_assistant.players] Handling command cmd_volume_set for player kitchen wiim
2024-09-01 16:53:08.689 DEBUG (MainThread) [music_assistant.webserver] Handling command players/cmd/volume_mute
2024-09-01 16:53:08.690 DEBUG (MainThread) [music_assistant.players] Handling command cmd_volume_mute for player livingroom wiim
2024-09-01 16:53:08.690 INFO (MainThread) [music_assistant.players] Player livingroom wiim does not support muting, using volume instead```

This seems to be the logs related ^

And complete logs below

music-assistant.log

Additional information

The players are all Wiim Pros

I used to manage their volume through a linkplay HACS integration; I would use a universal media player to merge them

What version of Home Assistant Core are your running

2024.8.3

What type of installation are you running?

Home Assistant OS

On what type of hardware are you running?

Generic x86-64 (e.g. Intel NUC)

marcelveldt commented 2 months ago

We do not have mute support in the airplay provider so instead volume is used to do fake muting - if you then use another way to override the volume this can cause issues. I suggest you to wait a bit until the linkplay provider in MA is operational

OzGav commented 2 months ago

Closing as explanation provided.