search

music-encoding / encoding-tools

Tools for working with or transforming MEI Encodings
Educational Community License v2.0
41 stars 32 forks source link

mei30To40.xsl missing <history> to contain <provenance> in MEI 4 #27

Closed paul-bayleaf closed 1 year ago

paul-bayleaf commented 2 years ago

mei30To40.xsl converts MEI 3 <physLoc> <provenance> into MEI 4 <physLoc> <provenance>

But this is not legal MEI 4, it is missing <history> it should be:

<physLoc> <history> <provenance>

mei30To40.xsl contains code to add <history> in this case, but this does not appear to be working. Attached before and after conversion, cut down from original MEI 3 as much as I can provenance.zip

musicEnfanthen commented 2 years ago

@pe-ro Do you have any idea why <history> isn't included in the MEI4 conversion? Seems that the physLoc match block is never applied? (https://github.com/music-encoding/encoding-tools/blob/main/mei30To40/mei30To40.xsl#L1023-L1035)

musicEnfanthen commented 2 years ago

And, thank you, @paul-bayleaf, for catching this issue!

musicEnfanthen commented 1 year ago

Fixed in e3b84f8