music-encoding / encoding-tools

Tools for working with or transforming MEI Encodings
Educational Community License v2.0
41 stars 32 forks source link

Fix issue 27 #29

Closed paul-bayleaf closed 1 year ago

paul-bayleaf commented 1 year ago

Fix Issue #27

mei30To40.xsl failed to convert MEI 3 \<physLoc> \<provenance> into MEI 4 \<physLoc> \<history> \<provenance>.

It should have matched the template on line 1024, but failed because it was in mode bibl, instead it matched the template on line 2427.

Fix changed the mode on line 1024 to mode="#all"

musicEnfanthen commented 1 year ago

Thank you @paul-bayleaf for investigating this bug and proposing a fix.

Maybe @pe-ro could have a quick look and confirm that changing the mode to "#all" is everything needed here?

musicEnfanthen commented 1 year ago

Thank you @paul-bayleaf for the fix, and the reviewers for double-checking!