Closed kepper closed 1 year ago
please also implement
- [ ] The values "italic" and "oblique" duplicate values available in data.FONTSTYLE. Fixes #1102https://github.com/music-encoding/music-encoding/pull/1188
@musicEnfanthen is this also tested in the docker-mei container?
please also implement
* [ ] The values "italic" and "oblique" duplicate values available in data.FONTSTYLE. Fixes #1102[Remove "italic" and "oblique" values from data.TEXTRENDITIONLIST music-encoding#1188](https://github.com/music-encoding/music-encoding/pull/1188)
That seems to open a whole other can of worms, as @rend
still contains other values like "bold" (which could go into @fontweight
), so this whole change seems half-baked. Are we really clear that this is the way to go for a v5 release?
please also implement
* [ ] The values "italic" and "oblique" duplicate values available in data.FONTSTYLE. Fixes #1102[Remove "italic" and "oblique" values from data.TEXTRENDITIONLIST music-encoding#1188](https://github.com/music-encoding/music-encoding/pull/1188)
That seems to open a whole other can of worms, as
@rend
still contains other values like "bold" (which could go into@fontweight
), so this whole change seems half-baked. Are we really clear that this is the way to go for a v5 release?
not applicable anymore as we undid the merge, cf. https://github.com/music-encoding/music-encoding/pull/1188#issuecomment-1592045421
Open issues:
<appInfo>
element to which it can add it's own information; if <appInfo>
is not there yet, it should be inserted. same is true for revisionDesc
for more please also refer to: #31
For the record: most of the issues mentioned in above are already fixed on my local clone
before proceeding though, I would like some feedback on https://github.com/music-encoding/sample-encodings/issues/77
seems to properly work on files from the sample collection