tools: first version of mei40To50.xsl

music-encoding / encoding-tools

Tools for working with or transforming MEI Encodings

Educational Community License v2.0

41 stars 32 forks source link

tools: first version of mei40To50.xsl #30

Closed kepper closed 1 year ago

kepper commented 1 year ago

seems to properly work on files from the sample collection

bwbohl commented 1 year ago

please also implement

~~- [ ] The values "italic" and "oblique" duplicate values available in data.FONTSTYLE. Fixes #1102https://github.com/music-encoding/music-encoding/pull/1188~~

bwbohl commented 1 year ago

@musicEnfanthen is this also tested in the docker-mei container?

kepper commented 1 year ago

please also implement

* [ ]  The values "italic" and "oblique" duplicate values available in data.FONTSTYLE. Fixes #1102[Remove "italic" and "oblique" values from data.TEXTRENDITIONLIST music-encoding#1188](https://github.com/music-encoding/music-encoding/pull/1188)

That seems to open a whole other can of worms, as @rend still contains other values like "bold" (which could go into @fontweight), so this whole change seems half-baked. Are we really clear that this is the way to go for a v5 release?

bwbohl commented 1 year ago

please also implement
* [ ]  The values "italic" and "oblique" duplicate values available in data.FONTSTYLE. Fixes #1102[Remove "italic" and "oblique" values from data.TEXTRENDITIONLIST music-encoding#1188](https://github.com/music-encoding/music-encoding/pull/1188)
That seems to open a whole other can of worms, as @rend still contains other values like "bold" (which could go into @fontweight), so this whole change seems half-baked. Are we really clear that this is the way to go for a v5 release?

not applicable anymore as we undid the merge, cf. https://github.com/music-encoding/music-encoding/pull/1188#issuecomment-1592045421

musicEnfanthen commented 1 year ago

Open issues:

[x] key.sig --> keysig (see music-encoding/music-encoding#933)
[x] "instrDef/@n" in from att.nNumberlike to att.nInterger (see music-encoding/music-encoding#933)
[x] keysig.show --> keysig.visible
[x] keysig.showchange --> keysig.cancelaccid (as the datatype changed from boolean to none, before, after, before-bar the values should be transfromed as follows: false --> none; true --> before [with a message that indicates the possibility of other values]
[x] the XSLT assumes there is already an <appInfo> element to which it can add it's own information; if <appInfo> is not there yet, it should be inserted. same is true for revisionDesc

for more please also refer to: #31

bwbohl commented 1 year ago

For the record: most of the issues mentioned in above are already fixed on my local clone

bwbohl commented 1 year ago

before proceeding though, I would like some feedback on https://github.com/music-encoding/sample-encodings/issues/77