Closed bwbohl closed 1 year ago
This probably needs #30 first, right? Can you have a look at the open suggestions there, please, @bwbohl ?
Can you have a look at the open suggestions there, please, @bwbohl ?
done
This probably needs #30 first, right?
Probably not, it targets the add-v5-transform branch. So first merge this, then test v5-transform (or ping me for testing it). Then we can merge v5-transform after having created a v4 release.
ping @kepper
Checklist for inclusion of changes in v5.0
fingerprint
pgFoot2
pgHead2
meterSig @form
@meter.form='invis'
-> @meter.visible='false'
metersig @form='invis'
-> metersig @visible='false'
in v4: @form
in att.meterSig.vis (optional)Contains an indication of how the meter signature should be rendered. Allowed values are: "num" (Show only the number of beats.), "denomsym" (The lower number in the meter signature is replaced by a note symbol.), "norm" (Meter signature rendered using traditional numeric values.), "invis" (Meter signature not rendered.)
@visible
visible
on mRest
@instr
instr
on mRest
instr
on mSpace
instr
on multiRest
instr
on rest
@text.dist
text.dist
on scoreDef
text.dist
on staffDef
text.dist
(use newly added dir.dist
, reh.dist
or tempo.dist
instead) in att.distances
@key.sig
-> @keysig
key.sig
->keysig
on scoreDef
key.sig
->keysig
on staffDef
key.sig
->keysig
in att.keySigDefault.log
@keysig.show
-> @keysig.visible
keysig.show
->keysig.visible
on scoreDef
keysig.show
->keysig.visible
on staffDef
keysig.show
->keysig.visible
in att.keySigDefault.vis
@showchange
->@cancelaccid
keysig.showchange
->keysig.cancelaccid
on scoreDef
keysig.showchange
->keysig.cancelaccid
on staffDef
sig.showchange
->cancelaccid
on keySig
sig.showchange
->cancelaccid
in att.keySig.vis
[bwb: should be captured by the above]keysig.showchange
->keysig.cancelaccid
in att.keySigDefault.vis
data.MIDINAMES
data.NOTEHEADMODIFIER.list
data.TEXTRENDITIONPAR
(letter-spacing|line-height)\((\+|-)?\d+(\.\d+)?%?\)
@letterspacing
and @lineheight
are now separate attributes in att.typography
, which means: rend="letter-spacing(0.25) line-height(120%)"
will be now letterspacing="0.25" lineheight="120%"
data.MIDIBPM
positive integer
to decimal number
~ does not need to be adjusted via XSLT
data.PERCENT
[0-9]+(\.?[0-9]*)?%
to [0-9]+(\.[0-9]*)?%
~ does not need to be adjusted via XSLT
data.PERCENT.LIMITED
(([0-9]|[1-9][0-9])(\.[0-9]+)?|100)%
to (([0-9]|[1-9][0-9])(\.[0-9]*)?|100(\.0*)?)%
~ does not need to be adjusted via XSLT
data.PERCENT.LIMITED.SIGNED
(\+|-)?(([0-9]|[1-9][0-9])(\.[0-9]+)?|100)%
to (\+|-)?(([0-9]|[1-9][0-9])(\.[0-9]*)?|100(\.0*)?)%
~ does not need to be adjusted via XSLT@musicEnfanthen there are so many things checked in the above list are you working on some modifications?
The checked things are already included in your version. I will add some suggestions to cover the missing cases.
I will add some suggestions to cover the missing cases.
You've been much faster, thanks :)
Thank you @bwbohl. I checked all the transformations for the section "MATCH TEMPLATES FOR CHANGES BETWEEN MEI v4 and MEI v5" with unit tests (using XSpec) and everything transforms great.
In case, anyone is interested in the XSpec file:
Thank you @bwbohl. I checked all the transformations for the section "MATCH TEMPLATES FOR CHANGES BETWEEN MEI v4 and MEI v5" with unit tests (using XSpec) and everything transforms great.
In case, anyone is interested in the XSpec file:
mei40To50_test.xspec
this is absolutely great!
This PR adds some changes that were introduced later or missed in the first place in #30 :
@key.sig
with@keysig
@keysig.showchange
with@keysig.cancelaccid
instrDef/@n
with@label
if contains non numerical content@meter.form="invis"
with@meter.visible="false"
And some improvements:
@meiversion
on root element if not presentmei:application
andmei:change
) even ifmei:encodingDesc
ormei:appInfo
, resp.mei:revisionDesc
are missing