tools: v5 transformation review of mei40To50.xsl

[bwbohl]

This PR adds some changes that were introduced later or missed in the first place in #30 :

• Replace @key.sig with @keysig
• Replace @keysig.showchange with @keysig.cancelaccid
• Replace instrDef/@n with @label if contains non numerical content
• Replace @meter.form="invis" with @meter.visible="false"

And some improvements:

• Always insert xml-model processing instructions; depending on preexisting or submitted value
• insert @meiversion on root element if not present
• insert self-documentation (mei:application and mei:change) even if mei:encodingDesc or mei:appInfo, resp. mei:revisionDesc are missing

[musicEnfanthen]

This probably needs #30 first, right? Can you have a look at the open suggestions there, please, @bwbohl ?

[bwbohl]

Can you have a look at the open suggestions there, please, @bwbohl ?

done

This probably needs #30 first, right?

Probably not, it targets the add-v5-transform branch. So first merge this, then test v5-transform (or ping me for testing it). Then we can merge v5-transform after having created a v4 release.

[bwbohl]

ping @kepper

[musicEnfanthen]

Checklist for inclusion of changes in v5.0

Removed elements

• [x] removed: fingerprint
• [x] removed: pgFoot2
• [x] removed: pgHead2

  Removed/changed attributes

  meterSig @form

• [x] @meter.form='invis' -> @meter.visible='false'
• [x] metersig @form='invis' -> metersig @visible='false' in v4: @form in att.meterSig.vis (optional)Contains an indication of how the meter signature should be rendered. Allowed values are: "num" (Show only the number of beats.), "denomsym" (The lower number in the meter signature is replaced by a note symbol.), "norm" (Meter signature rendered using traditional numeric values.), "invis" (Meter signature not rendered.)

  @visible

• [x] removed: visible on mRest
  • [x] test

    @instr

• [x] removed: instr on mRest
  • [x] test
• [x] removed: instr on mSpace
• [x] removed: instr on multiRest
• [x] removed: instr on rest
  • [x] test

    @text.dist

• [x] removed: text.dist on scoreDef
• [x] removed: text.dist on staffDef
• [x] removed: text.dist (use newly added dir.dist, reh.dist or tempo.dist instead) in att.distances

  @key.sig -> @keysig

• [x] changed: key.sig->keysig on scoreDef
• [x] changed: key.sig->keysig on staffDef
• [x] changed: key.sig->keysig in att.keySigDefault.log

  @keysig.show -> @keysig.visible

• [x] changed: keysig.show->keysig.visible on scoreDef
• [x] changed: keysig.show->keysig.visible on staffDef
• [x] changed: keysig.show->keysig.visible in att.keySigDefault.vis

  @showchange ->@cancelaccid

• [x] changed: keysig.showchange->keysig.cancelaccid on scoreDef
• [x] changed: keysig.showchange->keysig.cancelaccid on staffDef
• [x] changed: sig.showchange->cancelaccid on keySig
• [x] changed: sig.showchange->cancelaccid in att.keySig.vis [bwb: should be captured by the above]
• [x] changed: keysig.showchange->keysig.cancelaccid in att.keySigDefault.vis

  data.MIDINAMES

• [x] Bagpipe -> Bag_pipe

  data.NOTEHEADMODIFIER.list

• [x] dblwhole -> fences

  data.TEXTRENDITIONPAR

• [x] removed datatype value: (letter-spacing|line-height)\((\+|-)?\d+(\.\d+)?%?\) @letterspacing and @lineheight are now separate attributes in att.typography, which means: rend="letter-spacing(0.25) line-height(120%)" will be now letterspacing="0.25" lineheight="120%"

  data.MIDIBPM

• [x] ~type of allowed values changed from positive integer to decimal number~ does not need to be adjusted via XSLT

  data.PERCENT

• [x] ~regex of allowed values changed from [0-9]+(\.?[0-9]*)?% to [0-9]+(\.[0-9]*)?%~ does not need to be adjusted via XSLT

  data.PERCENT.LIMITED

• [x] ~regex of allowed values changed from (([0-9]|[1-9][0-9])(\.[0-9]+)?|100)% to (([0-9]|[1-9][0-9])(\.[0-9]*)?|100(\.0*)?)%~ does not need to be adjusted via XSLT

  data.PERCENT.LIMITED.SIGNED

• [x] ~regex of allowed values changed from (\+|-)?(([0-9]|[1-9][0-9])(\.[0-9]+)?|100)% to (\+|-)?(([0-9]|[1-9][0-9])(\.[0-9]*)?|100(\.0*)?)%~ does not need to be adjusted via XSLT

[bwbohl]

@musicEnfanthen there are so many things checked in the above list are you working on some modifications?

[musicEnfanthen]

The checked things are already included in your version. I will add some suggestions to cover the missing cases.

[musicEnfanthen]

I will add some suggestions to cover the missing cases.

You've been much faster, thanks :)

[musicEnfanthen]

Thank you @bwbohl. I checked all the transformations for the section "MATCH TEMPLATES FOR CHANGES BETWEEN MEI v4 and MEI v5" with unit tests (using XSpec) and everything transforms great.

In case, anyone is interested in the XSpec file:

mei40To50_test.xspec

```xml 1234567890 1234567890 Test header 1 should have func=first Test header 2 should have func=all Test header 2 should have func=all Test header 1 should have func=first Test header 2 should have func=all Test header 1 should have func=first Test header 1 should have func=first Test header 2 should have func=all Test header 1 should have func=first Test header 2 should have func=all Test footer 1 should have func=first Test footer 2 should have func=all Test footer 2 should have func=all Test footer 1 should have func=first Test footer 2 should have func=all Test footer 1 should have func=first Test footer 1 should have func=first Test footer 2 should have func=all Test footer 1 should have func=first Test footer 2 should have func=all ```

[bwbohl]

Thank you @bwbohl. I checked all the transformations for the section "MATCH TEMPLATES FOR CHANGES BETWEEN MEI v4 and MEI v5" with unit tests (using XSpec) and everything transforms great.

In case, anyone is interested in the XSpec file:

mei40To50_test.xspec

this is absolutely great!