music-encoding / guidelines

:scroll: The Music Encoding Initiative Guidelines
Educational Community License v2.0
23 stars 29 forks source link

Links to TEI guidelines still broken #196

Closed musicEnfanthen closed 3 years ago

musicEnfanthen commented 3 years ago

Related to music-encoding/music-encoding#743

In the latest dev version, the links to the TEI guidelines in Chapter 14.4 SVG are still broken because they are resolved to:

https://tei-c.org/release/doc/tei-p5-doc/en/html/ref-moduleRef.html.html

Is it possible that the $text variable in the guidelines.xsl already inlcudes the .html, or where does the double html come from?

bwbohl commented 3 years ago

https://github.com/music-encoding/music-encoding/blob/e02b5fe1f700ff3df0b1e57ceafc2ec8af39e024/utils/guidelines_xslt/odd2html/guidelines.xsl#L130

shows $text is the text content of the tei:gielement in the case of:

https://github.com/music-encoding/music-encoding/blob/e02b5fe1f700ff3df0b1e57ceafc2ec8af39e024/source/docs/14-integration.xml#L122

it consequently is moduleRef and gets concatenated to the uri with:

https://github.com/music-encoding/music-encoding/blob/e02b5fe1f700ff3df0b1e57ceafc2ec8af39e024/utils/guidelines_xslt/odd2html/guidelines.xsl#L133

at the moment I dont see where the second .htmlcomes from…

bwbohl commented 3 years ago

@kepper could you have a look?

kepper commented 3 years ago

will do

kepper commented 3 years ago

As I used the same class name for external TEI links, and the treatment for links for the website was based on those css classes, I've adjusted the link as I have to for our internal links. Thanks for spotting this 👍

musicEnfanthen commented 3 years ago

Great. Would it work then with doc-available again?

kepper commented 3 years ago

Probably not – that check is done at an earlier stage, before the duplicate .html got introduced, so that the fix above doesn't affect it…

musicEnfanthen commented 3 years ago

Ah, ok. Thanks for fixing it 👍