search

music-encoding / music-encoding.github.io

The MEI website
http://music-encoding.org
Educational Community License v2.0
15 stars 37 forks source link

fix: exclude xitter from broken link checker #578

Closed musicEnfanthen closed 5 months ago

musicEnfanthen commented 5 months ago

In #575, Xitter was excluded from the lycheeverse action. However, issues like #577 were raised from broken link checker action. This PR adds the exclusion keywords in that action.

Fixes #577

musicEnfanthen commented 5 months ago

BTW, the broken link checker action has been archived since 2022. Did not find a better alternative so far (was playing around with Muffet which is nice, but gives an issue for almost every link on music-encoding.org :( ). So any ideas welcome!

rettinghaus commented 5 months ago

@musicEnfanthen How about using only lychee to check the gh-pages branch on music-encoding.github.io?

musicEnfanthen commented 5 months ago

@rettinghaus Lychee checks only the "code-side" of the links, i.e., it goes through all the repo files and checks the given links. The other actions checks those links when rendered live on the webpage. Although there should not be a big difference, we see sometimes different behaviours in one of those perspectives (cf. this twitter issue).

musicEnfanthen commented 5 months ago

@rettinghaus But if there is a way to use lychee to check the live website as well, would be great!