search

music-encoding / music-encoding.github.io

The MEI website
http://music-encoding.org
Educational Community License v2.0
15 stars 37 forks source link

Fix link checker #579

Closed musicEnfanthen closed 5 months ago

musicEnfanthen commented 5 months ago

After some time of debugging, this PR improves the link checker configuration to handle the failing tutorial paths correctly. When Jekyll builds the website, all the paths in the original _tutorials folder get flattened and the files land in the same output folder tutorials (with no subfolder).

To fix this in the remap option of the lychee toml, regex is our friend (although this is not very well documented in the lychee docs; only explicitly mentioned for exclude and include paths).

It also fixes the remaining broken links resp. false positives issued by lychee.

Fixes #576 Fixes #574 Fixes #568 Fixes #565 Fixes #561

bwbohl commented 5 months ago

any chance I test this before merging?

bwbohl commented 5 months ago

to be more precise is there a way to test this before merging?

rettinghaus commented 5 months ago

You can copy this branch and start the action manually.

musicEnfanthen commented 5 months ago

Yes, there is a workflow dispatch trigger that allows you to trigger the action FROM a specific branch FOR a specific branch.

Also, you can have a look at the last action run of the PR branch: https://github.com/musicEnfanthen/music-encoding.github.io/actions/runs/7776307814