search

music-encoding / music-encoding.github.io

The MEI website
http://music-encoding.org
Educational Community License v2.0
15 stars 37 forks source link

Do only build from main branch #609

Closed musicEnfanthen closed 2 months ago

musicEnfanthen commented 2 months ago

This PR adds a branch filter to the build script, so the website gets only build when there are pushes to the main branch.

Fixes #608

musicEnfanthen commented 2 months ago

That's automatic, did not do anything to that line ending. Will try to undo.

rettinghaus commented 2 months ago

Some hints: https://docs.github.com/en/get-started/getting-started-with-git/configuring-git-to-handle-line-endings

musicEnfanthen commented 2 months ago

Thanks. The thing is, I've created this PR purely on GitHub UI. No local git involved. ❓

And locally, I have recommended core.autocrlf=true setting (which uses CRLF on Win checkouts, but converts to Unix style LF when you commit files).

musicEnfanthen commented 2 months ago

Wrong base branch

musicEnfanthen commented 2 months ago

Superseded by #610

musicEnfanthen commented 2 months ago

PS: It seems that the default line ending used by GH is CRLF, see https://github.com/actions/runner/issues/1462#issuecomment-1030124116:

Hi @marcellp, this is how pull requests work on GitHub, it is not specific to the runner. The GitHub API uses \r\n as line breaks within pull requests, which you can see with the /repos/{org}/{repo}/pulls/{pr_number} API; the body in the Actions event matches the body of the PR, as it is stored. GitHub Actions does not mutate this, it gives it to you verbatim. If you want a modified version of the PR body, you'll need to do it yourself.