search

music-encoding / sibmei

Sibelius MEI Plugin
MIT License
39 stars 16 forks source link

Lyrics in chords #129

Closed th-we closed 4 years ago

th-we commented 4 years ago

I rebased #124 #122 and added a test for #124. I'd close #124 and #122 and merge this one.

th-we commented 4 years ago

Oh well, I got confused with the commits and pull requests again – sorry for mixing up #122 and #124. I'll check the offset related commit now – that's the one I actually rebased.

annplaksin commented 4 years ago

Is it possible to get rid of the two commits for #122 ? The rest looks fine to me.

rettinghaus commented 4 years ago

If I'm not mistaken, you merged the changes from #122 and #124 without changing the version number? Looks fine to me.

th-we commented 4 years ago

Yeah, give me some time to sort it out. I shouldn't be doing too many things in parallel.

rettinghaus commented 4 years ago

@th-we I'm still a bit confused: this PR combines #122 and #124 with some lines from you for testing. What about the version number now? @annplaksin Are you ok with this, or would you prefer three separate PRs?

annplaksin commented 4 years ago

Nope, the changes changes seem fine to me. Would you like to merge @rettinghaus ?