Closed th-we closed 3 years ago
@rettinghaus please undo this -- it contains changes that have been 'leaked' in from another PR, that I'm not quite ready to approve.
Sorry I messed something up here.
@th-we please open a new PR for this.
Sorry, I overlooked the changes in the libmei as they were to many to be displayed in the diff. Since PRs cannot be reopned, a new PR would be the best idea... the improvements of the text handling are useful though.
Agreed -- the text improvements should be kept on a separate branch.
In fact, in general I would suggest making only changes that need to be made for a certain bit of functionality. I know the temptation is high to "just do this one thing", but it makes it really hard for reviewers to know whether a change is intentional or will cause problems. (Like this PR changing the tuplet._parent = null;
line -- not sure why that needs to be changed in a PR that is for text handling).
@ahankinson The tuplet._parent = null
removal is because in that commit, that functionality was moved to libmei. I'll create more granular pull requests, leaving out the XML parser removal.
Main differences:
Indentation
If there is text content, libmei won't intersperse it with formatting white space any more. This is especially important for the new text formatting features. If we have original text without whitespace in between, we don't want this:
We do want this:
Formatting tracking
The logic for tracking how the rendering state changes while traversing a formatted string is less twisted and more robust now.