search

music-encoding / sibmei

Sibelius MEI Plugin
MIT License
40 stars 16 forks source link

Merge PrevNormalOrGrace() and NextNormalOrGrace() #190

Closed th-we closed 2 years ago

th-we commented 2 years ago

Apparently, I added a check for null in NextNormalOrGrace() which I forgot in PrevNormalOrGrace(), which is a 1:1 copy with only some renamed variables and method calls. To prevent code diversion in this duplicated code, I merged both functions.

th-we commented 2 years ago

Rename function

Is the naming in af7b8af better?

th-we commented 2 years ago

@ahankinson I really have to thank for your review work. So thorough and well communicated. 🙏