search

music-encoding / sibmei

Sibelius MEI Plugin
MIT License
40 stars 16 forks source link

add technique text handling #201

Closed rettinghaus closed 1 year ago

rettinghaus commented 1 year ago

This adds a CreateDirective function to handle staff text, in this case text.staff.technique. Also it unifies some names.

rettinghaus commented 1 year ago

@th-we Could you please have another look here?

th-we commented 1 year ago

@rettinghaus Can you merge my new pull request on your branch, and then we merge this pull request here?

rettinghaus commented 1 year ago

Done. Sorry I overlooked it.

th-we commented 1 year ago

Done. Sorry I overlooked it.

It wasn't there before, I just added it!

th-we commented 1 year ago

@rettinghaus I created another pull request to fix an error.

ahankinson commented 1 year ago

I'm going to approve this.