search

music-encoding / sibmei

Sibelius MEI Plugin
MIT License
40 stars 16 forks source link

Fixed: Use corresp instead of startid for fb #205

Closed ahankinson closed 1 year ago

ahankinson commented 1 year ago

Changes the <harm> element for figured bass to use @corresp instead of @tstamp for the note that it is attached to. This should still correspond to the nearest previous bar object. This is to deal with situations like the following, where the figure is attached to the first note in the bar, but should be positioned on the third beat.

image

See the discussion in #192 for additional context.

Fixes #192

ahankinson commented 1 year ago

Thanks! I verified with Laurent that it would not affect Verovio to use @corresp but that it would fix the specific issue: https://github.com/rism-digital/verovio/issues/2533

The idea being that @corresp would still keep some semantic relationship to the "active" note, but without the @startid implying that the figures both "start" on the same note.

craigsapp commented 1 year ago

I'm not super happy to use @corresp for this, but it's still the best move we can make here, I guess.

It seems like an interesting idea and would be useful if you need to realize the figured bass since the @corresp would help you find the note that goes with the figures.

Similar to the finding the duration/pitches of the repeated chord symbol discussed last week on the mei-encoding repo (I think).