music-encoding / sibmei

Sibelius MEI Plugin
MIT License
40 stars 16 forks source link

Unify and improve batch export code #213

Closed th-we closed 11 months ago

th-we commented 11 months ago

Code for batch export from Sibelius and MusicXML was almost identical, but slowly diverged. Now it's unified again.

Additional improvements:

The progress dialog was removed because after a split second, it is overridden by the progress dialog looping over the bars of each file anyways.

Could someone please test on a Mac before merging? Especially how the MusicXML export works.

rettinghaus commented 11 months ago

With the latest Sibelius version I get this: image

th-we commented 11 months ago

Huh? That is really strange. Can you make sure that sibmei4.plg is somewhere in your Sibelius Plugins folder and that it was not accidentally unloaded?

Thanks a bunch for testing, @rettinghaus!

th-we commented 11 months ago

@rettinghaus If you could try again that would be superb. I pushed two more commits, which are most likely unrelated to the problem you reported, but anyways...

rettinghaus commented 11 months ago

So I did more tests. The first problem was indeed my fault, but now I'm getting this error

image

I tried different folders and also the Batch-Sibelius-Export, all with the same result.

Running Sibelius 2023.8

NB: Direct export works fine

rettinghaus commented 11 months ago

Sorry again, I didn't saw your latest changes. Another test round and everything seems to work, so I'll just merge. Thanks for the effort!