search

music-notation-swift / music-notation-core

Music Notation Library in Swift (Deprecated. See `music-notation` instead)
MIT License
115 stars 16 forks source link

Rename all occurrences of Tone to Pitch #124

Closed massimobio closed 6 years ago

massimobio commented 6 years ago

Quite a large PR here but there were a lot of uses of "tone". Also fixed related file names, comments and made sure to correctly pluralize tones to pitches. I'm not sure what the class diagram is, that is mentioned in #113

codecov[bot] commented 6 years ago

Codecov Report

Merging #124 into master will not change coverage. The diff coverage is 99.75%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #124   +/-   ##
=======================================
  Coverage   97.48%   97.48%           
=======================================
  Files          32       32           
  Lines        5809     5809           
=======================================
  Hits         5663     5663           
  Misses        146      146
Impacted Files Coverage Δ
...ts/MusicNotationCoreTests/MeasureRepeatTests.swift 84.95% <ø> (ø) :arrow_up:
Tests/MusicNotationCoreTests/NoteTests.swift 100% <100%> (ø) :arrow_up:
Tests/MusicNotationCoreTests/ClefTests.swift 100% <100%> (ø) :arrow_up:
...ationCoreTests/MeasureDurationValidatorTests.swift 100% <100%> (ø) :arrow_up:
Tests/MusicNotationCoreTests/PitchTests.swift 100% <100%> (ø)
Sources/SpelledPitch.swift 100% <100%> (ø)
Sources/Measure.swift 88.98% <100%> (ø) :arrow_up:
Tests/MusicNotationCoreTests/MeasureTests.swift 100% <100%> (ø) :arrow_up:
Sources/Staff.swift 91.9% <100%> (ø) :arrow_up:
Sources/Clef.swift 96.55% <100%> (ø) :arrow_up:
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4cb0327...14afe3e. Read the comment docs.

drumnkyle commented 6 years ago

I updated the class diagram for you. It uses the software: UMLet

drumnkyle commented 6 years ago

I appreciate you doing this work. However, I just remembered that I have an open PR that isn't completed yet called clefPerNote. It has major changes to the way clefs work. So, this will cause a lot of merge conflicts most likely. So, I'd like to delay this for after that is completed.

massimobio commented 6 years ago

Makes sense. Waiting on completion of #118