music-notation-swift / music-notation-core

Music Notation Library in Swift (Deprecated. See `music-notation` instead)
MIT License
115 stars 16 forks source link

Swift4xcode9changes #131

Closed massimobio closed 6 years ago

massimobio commented 6 years ago

As @drumnkyle anticipated, not much needed change for Swift 4 🎉

codecov[bot] commented 6 years ago

Codecov Report

Merging #131 into master will not change coverage. The diff coverage is 80%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #131   +/-   ##
=======================================
  Coverage   97.48%   97.48%           
=======================================
  Files          32       32           
  Lines        5809     5809           
=======================================
  Hits         5663     5663           
  Misses        146      146
Impacted Files Coverage Δ
Sources/Tuplet.swift 91.98% <100%> (ø) :arrow_up:
Sources/ImmutableMeasure.swift 95% <100%> (ø) :arrow_up:
Tests/MusicNotationCoreTests/TestHelpers.swift 94.44% <66.66%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4cb0327...7e3aa3b. Read the comment docs.

drumnkyle commented 6 years ago

I was thinking we should go right to Xcode 10.

Sent with GitHawk

massimobio commented 6 years ago

I though so too, but with a quick look it seemed to me that Travis only supports up to Xcode 9. Not that we are using Travis to its full potential right now 😂

drumnkyle commented 6 years ago

Yeah. We should take a task to use a lot more of Travis. Ok, let’s just go for this for now then. Thanks! I’ll take a look at it thoroughly in a little bit.

Sent with GitHawk