search

music-notation-swift / music-notation-core

Music Notation Library in Swift (Deprecated. See `music-notation` instead)
MIT License
115 stars 16 forks source link

InsertMeasure & InsertRepeat #19

Closed drumnkyle closed 8 years ago

drumnkyle commented 8 years ago

Fixes #9. Staff.insertMeasure and Staff.insertRepeat

codecov-io commented 8 years ago

Current coverage is 85.93% (diff: 100%)

Merging #19 into master will increase coverage by 0.08%

@@             master        #19   diff @@
==========================================
  Files            12         12          
  Lines           657        661     +4   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits            564        568     +4   
  Misses           93         93          
  Partials          0          0

Powered by Codecov. Last update 1f6b0bf...c6009d8

moidx commented 8 years ago

Looks good, I think this makes the repeated measures more user friendly.

drumnkyle commented 8 years ago

@robtimp if you'd like to leave a comment of what you think the documentation for be for the insertMeasure method or if it makes sense to you, that would be great.

I'm going to make a change so that the inRepeat param is only checked when the index is the beginning of a repeat.