search

music-notation-swift / music-notation-core

Music Notation Library in Swift (Deprecated. See `music-notation` instead)
MIT License
115 stars 16 forks source link

Add additional clefs #59

Closed robtimp closed 8 years ago

robtimp commented 8 years ago

Resolves #46

codecov-io commented 8 years ago

Current coverage is 86.23% (diff: 100%)

Merging #59 into master will not change coverage

@@             master        #59   diff @@
==========================================
  Files            12         12          
  Lines           661        661          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits            570        570          
  Misses           91         91          
  Partials          0          0

Powered by Codecov. Last update b0f73b2...390df4b

drumnkyle commented 8 years ago

@robtimp Please look at my comments on the issue. This is a good change, but I want to make sure this is the full change needed to resolve the issue.

robtimp commented 8 years ago

@drumnkyle Could you specify what more you'd like me to add? There's a few more quite obscure clefs, or we could add a case for a custom clef.

drumnkyle commented 8 years ago

Sorry. I was thinking of #58. I will merge this since it is separate. Can you take a look at my comments on #58 so we can figure out what change is necessary to resolve that issue?