music-notation-swift / music-notation-core

Music Notation Library in Swift (Deprecated. See `music-notation` instead)
MIT License
115 stars 16 forks source link

Refactored Tuplet validation to use NoteDuration.ticks #71

Closed drumnkyle closed 8 years ago

drumnkyle commented 8 years ago

Fixes #69. All information is detailed in that issue.

codecov-io commented 8 years ago

Current coverage is 85.29% (diff: 100%)

Merging #71 into master will increase coverage by 0.12%

@@             master        #71   diff @@
==========================================
  Files            14         14          
  Lines           775        775          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits            660        661     +1   
+ Misses          115        114     -1   
  Partials          0          0          

Powered by Codecov. Last update f036c78...b9dfeab

drumnkyle commented 8 years ago

I'm not totally convinced on the naming of NoteDuration.ticks, but it's what I have for now. We can revisit later if we want. I am going to push now so that I am unblocked for #30.