Tuplet replace note - Githubissues

music-notation-swift / music-notation-core

Music Notation Library in Swift (Deprecated. See `music-notation` instead)

MIT License

115 stars 16 forks source link

Tuplet replace note #81

Closed drumnkyle closed 8 years ago

drumnkyle commented 8 years ago

This fixes #72.

[x] Fix removeNotes method
[x] Implement tests for Tuplet.replaceNotes(in:with:[T])
[x] Handle ties

codecov-io commented 8 years ago

Current coverage is 95.64% (diff: 95.88%)

Merging #81 into master will increase coverage by 8.77%

@@             master        #81   diff @@
==========================================
  Files            15         25     +10   
  Lines           876       3603   +2727   
  Methods           0          0           
  Messages          0          0           
  Branches          0          0           
==========================================
+ Hits            761       3446   +2685   
- Misses          115        157     +42   
  Partials          0          0

Powered by Codecov. Last update b97b8a4...1293b16

drumnkyle commented 8 years ago

I hit a tough bug to fix that seems like it will be complicated. If you could take a look at the TODO in the code and the OneNote document and give me any help, that would be great. Otherwise, I will come back to it another day.

drumnkyle commented 8 years ago

This is ready to go. If @robtimp, @migue48 could take a look that would be great. I will merge it at some point probably either way, because it's a lot of code and I understand if you don't review it ;)