Closed robtimp closed 8 years ago
@drumnkyle @migue48 I feel like the question of whether to display a natural before a note is one of presentation rather than semantics.
Thoughts?
@@ master #82 diff @@
==========================================
Files 15 15
Lines 877 876 -1
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 763 761 -2
- Misses 114 115 +1
Partials 0 0
Powered by Codecov. Last update baf5204...05aa308
Addresses issue #76
I believe make the Accidental type non-optional for Tone and KeySignature will help prevent some odd behavior and make for a more consistent model.
I've also reordered the initializer for Tone to place accidental after note letter, which better matches how we natural refer to the notes (i.e. G-sharp, not sharp-G).