search

music-notation-swift / music-notation-core

Music Notation Library in Swift (Deprecated. See `music-notation` instead)
MIT License
115 stars 16 forks source link

Created Clef struct and tests for it #94

Closed drumnkyle closed 7 years ago

drumnkyle commented 8 years ago

Fixes #91. However, I did not make the capability to make a standard clef down an octave or up an octave. Not sure how we want to do that.

codecov-io commented 8 years ago

Current coverage is 96.52% (diff: 99.12%)

Merging #94 into master will increase coverage by 0.80%

@@             master        #94   diff @@
==========================================
  Files            27         31     +4   
  Lines          3670       4056   +386   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits           3513       3915   +402   
+ Misses          157        141    -16   
  Partials          0          0

Powered by Codecov. Last update 02c1e6c...3c579d2

drumnkyle commented 8 years ago

@robtimp I will push this soon unless there are any objections. I've made the changes you've suggested.

drumnkyle commented 8 years ago

I modified it according to your suggestions @robtimp, but went a bit in a different direction implementation-wise. Let me know if what you think.

drumnkyle commented 8 years ago

@robtimp: I added a bunch of logic for Clef.tone(at:). Please take a look and make sure you are good with everything. I'd like to push this. @migue48: probably would be good for you to look over my math as well. I don't know if there is any easier math technique I couldn't think of, but I think I covered all of the cases.