search

music-notation-swift / music-notation-core

Music Notation Library in Swift (Deprecated. See `music-notation` instead)
MIT License
115 stars 16 forks source link

Implement `NoteCollection.groupingOrder` #96

Closed moidx closed 8 years ago

moidx commented 8 years ago

Grouping order is used to calculate the total number of ticks in a Tuplet. NoteCollection.noteCount returns now the number of notes in the notes container.

moidx commented 8 years ago

This pull request fixes issue #87

codecov-io commented 8 years ago

Current coverage is 95.60% (diff: 100%)

Merging #96 into master will decrease coverage by 0.03%

@@             master        #96   diff @@
==========================================
  Files            25         25          
  Lines          3603       3618    +15   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits           3446       3459    +13   
- Misses          157        159     +2   
  Partials          0          0

Powered by Codecov. Last update 7353080...838e854

moidx commented 8 years ago

Branch is ready to be merged. Just need to complete the code review.

drumnkyle commented 8 years ago

@robtimp please take a look at this and make sure you agree with the name or propose a new one if you have a better idea.