search

musically-ut / first-timers-only-bot

① First timers only issue tweeting bot.
https://twitter.com/first_tmrs_only
BSD 3-Clause "New" or "Revised" License
51 stars 22 forks source link

Specify label in tweet #4

Open hiimbex opened 6 years ago

hiimbex commented 6 years ago

Hiya! I love the additional support for labels you've added in https://github.com/musically-ut/first-timers-only-bot/pull/3: https://github.com/musically-ut/first-timers-only-bot/blob/7438415d15e4a6f54666230a7aff46c35df44942/first_timers/first_timers.py#L10-L13

But I think it might be nice to clarify what label was assigned in the tweet. For example, an up-for-grabs issue probably isn't as new person friendly as first-timers-only.

So I'd suggest beginning the tweet with [label-name]. It would probably be a pretty simple change. Let me know what you think!

musically-ut commented 6 years ago

This sounds like a reasonable thing. The only problem is the 140 character limit. I have had to do some gymnastics with the tweet text:

https://github.com/musically-ut/first-timers-only-bot/blob/a25545b2c14974b3c37ab504a65d9df63ab5bf7a/first_timers/first_timers.py#L66-L70

I'll keep the label information at this point and reduce the text further.

What would be better, though: [label-name] (2 extra characters) or #label-name hashtag (1 extra character)? How does Twitter handle dashes in hash-tags?

hiimbex commented 6 years ago

I think the hashtag is much better actually, it makes use of what's built into twitter better. It'll be easier to search for on twitter too. I'm not sure about hyphens 🤔

cg-cnu commented 6 years ago

twitter don't allow the hashtags with hypens. screenshot 61 screenshot 62 While there are many forms the one with CamelCase is generally suggested for readability. I guess we can use #FirstTimersOnly as the hashtag. There is already lot of content with that tag We need a way to convert the content from hypen to CamelCase.

musically-ut commented 6 years ago

CamelCase also saves some characters. :)

cg-cnu commented 6 years ago

DoubleKill 😄

hiimbex commented 6 years ago

Awesome! I'm pretty busy in the near future, so I might not get around to it, if you wanna throw on an up for grabs label?

If no one picks it up, I'd do it eventually, but I'd rather give someone more interested in learning twitter bots an opportunity to work on this.

archime commented 5 years ago

@hiimbex Old issue, but the bot is still active so wondering if I can help. I'm in both the #Beginners and #FirstTimersOnly categories... let me know if you're open to it.

My understanding of the spec is essentially: add a CamelCase hashtag at the end of each tweet specifying the relevant label (first-timers-only, low-hanging-fruit, up-for-grabs, beginners) while staying under 140 characters.

Edit: Tagging @musically-ut as well

musically-ut commented 5 years ago

@archime Thanks for pitching in!

Things have evolved a bit since the issue was originally posted. As a response to the discussion in #3 , we ended up removing the support for other labels because the bot started tweeting too much:

https://github.com/musically-ut/first-timers-only-bot/blob/master/first_timers/first_timers.py#L11

Hence, the issue became a bit moot. However, since I am open to adding more labels, it is still a good idea to work on this, IMO. Hence, 👍 from my side.

Sidenotes: I think that Twitter has become a little more generous about the 140 character limit.