musically-ut / lovely-forks

💚 🍴 Show notable forks of GitHub repositories under their names.
Mozilla Public License 2.0
603 stars 40 forks source link

Don't show for private repositories #12

Closed JaKXz closed 8 years ago

JaKXz commented 8 years ago

it would be great if the extension didn't make any calculations if the repo being looked at is private.

musically-ut commented 8 years ago

Interesting. I don't have a private repo handy to test this, but I will try to lay my hands on some.

In the meanwhile, does this extension break the user experience on Github in someway on private repos by throwing errors or messing up the display?

JaKXz commented 8 years ago

@musically-ut it doesn't break anything, but it does just display a "no information" string, which isn't really helpful.

musically-ut commented 8 years ago

Ah, the error message actually is that Github didn't provide any information about the repo. I think I just should keep the place blank instead of showing "no information" there.