search

musically-ut / lovely-forks

💚 🍴 Show notable forks of GitHub repositories under their names.
Mozilla Public License 2.0
603 stars 40 forks source link

Add more fork options #21

Closed ProLoser closed 3 years ago

ProLoser commented 8 years ago

I've been wanting to add something like this for a while to my Github Omnibox extension any interest in merging efforts?

Anyway, I think it'd be nice if you didn't limit suggestions to only the primary fork, but continue showing forks everywhere. Also, I might change the text and suggestion to be a bit more informative like "also a popular fork: [x/y]()" for the fork with the second-highest stars and "also an active fork: [x/y]()" for the one with the most recent commit(s). It would be nice if it could also count the number of commits. The flame icon doesn't really illustrate much. You would be able to combine them asl: "also a popular active fork: [x/y]()"

I think it'd also be cool if it was a dropdown (on hover) maybe triggered by an ellipses or down arrow that lets you see the top 3-5 most popular / active forks?

My chrome extension adds a dropdown so it's not too difficult:

screen shot 2016-03-16 at 11 48 11 am
musically-ut commented 8 years ago

Thanks for the suggestions. Omnibox is a great extension! :)

Responses inline.

any interest in merging efforts?

I am ambivalent about the merge. With recent changes to Chrome, the extensions have become obnoxiously visible and it is better to keep them to a minimum. However, on the other hand, I would like to maintain Firefox compatibility. So I would wait for a bit to see how the extension ecosystem evolves. Or, we could attempt to abstract out the functioning and keep it at both places. Suggestions?

Anyway, I think it'd be nice if you didn't limit suggestions to only the primary fork, but continue showing forks everywhere.

The UI was the primary problem, though I've found that the community usually converges to only one maintained fork. I like your suggestion about creating a small hover card showing the other forks in order of stargazers. However, getting the recency information about those other forks leads me to the second point.

"also an active fork: x/y" for the one with the most recent commit(s). ... It would be nice if it could also count the number of commits.

At the moment, I am using Github's compare API to determine if the default branch of the fork is ahead of the same branch on the origin, i.e., the difference between number of ahead_by commits and number of behind_by commits is positive. This is, at best, a guess which Ivan suggested since the other pieces of information about recency of repositories provided by Github API are misleading. I am not sure whether I would show these numbers because of they are, after all, an heuristic. Also, it may change, as it already has from comparing the time of the recent commits to comparing pushed at times to counting commits.

Additionally, Lovely Forks does not, at the moment, allow for Github authentication. It uses two API calls for each Github page (and caches results): one to get the list of forks ordered by stargazers (which is sufficient for showing a list of active forks) and the second to the compare API to guess the recency. Adding more API calls to determine improved recency information is not very alluring, especially if the information is going to be hard to interpret/use anyway.

What did you mean by "x/y"?

ProLoser commented 8 years ago

Owner/repo

fregante commented 7 years ago

any interest in merging efforts?

The two extensions are completely unrelated. You can merge efforts by cross-contributing but it doesn't make sense to merge just to save an icon (which can be hidden anyway)

Anyway, I think it'd be nice if you didn't limit suggestions to only the primary fork, but continue showing forks everywhere.

If you want to see more forks, you can click the fork button fork button or add a link to the members page

musically-ut commented 3 years ago

Now there is useful-forks.github.io to solve the same problem.