musically-ut / lovely-forks

💚 🍴 Show notable forks of GitHub repositories under their names.
Mozilla Public License 2.0
593 stars 40 forks source link

RFE: Version compatible w/ Pale Moon #22

Open TPS opened 8 years ago

TPS commented 8 years ago

@musically-ut Could you work out compatibility with Pale Moon? More info @ Why do some extensions not work in Pale Moon?

musically-ut commented 8 years ago

Thanks for the suggestion!

I don't have a Windows machine available locally. So I am going to need some help from you in implementing this.

The requirement only appears to be that I drop the compatibility of the extension to a Firefox version below 25. You can try this version of the xpi, where I have lowered the minimum Firefox version required and tell me whether it works.

Additionally, you can try disabling the compatibility checks: https://addons.mozilla.org/en-US/firefox/addon/checkcompatibility/

Thanks!

TPS commented 8 years ago

Thanks! When I get back to my laptop (probably the weekend), I'll try it out & let you know how well it does.

Also, just FYI, there exists an officially supported PaleMoon Linux port.

I couldn't download the DropBox file, so I tried my hand @ updating install.rdf myself for v2.5.0 & v2.1.0 (last version that showed Ff 26 compatibility, as PM advertises for Ff25.x). Both now install, but neither function, so I think there's something internally that requires something that PM doesn't have. Anything else you want me try?

P.S.: I've now attached the modified XPIs

lovely_forks-2.1.0-fx+an.xpi.zip lovely_forks-2.5.0-an+fx.xpi.zip

(just remove .Zip @ end). Also, PM doesn't check XPI sigs, due to Mozilla not exposing how it's done properly.

musically-ut commented 8 years ago

I am surprised that it was difficult to download from Dropbox. However, thanks for taking the time and making the effort for testing it.

There was an issue which broke the extension on SeaMonkey. Perhaps the same issue could be afflicting Pale Moon?

It could also be an SDK issue (this plugin does make use of the SDK which may not be fully supported on Pale Moon).

I will try it on a Linux machine, investigate and report back.

TPS commented 8 years ago

The info pointed to from Add-on SDK documentation for Pale Moon might be helpful, also.

(The Dropbox problems could have to do with my ad-blocking settings, but that's not really an issue now.…)

TPS commented 8 years ago

Also, this from the roadmap is likely relevant:

JetPack (Add-on SDK) extensions

JetPack (add-on SDK) add-ons are discouraged for Pale Moon, because they inherently run into compatibility issues for multi-application targeting due to its divergent nature from other Mozilla applications. If you still like to develop JetPack add-ons for Pale Moon, you will likely have to make a completely separate extension specific for Pale Moon targeting. Pale Moon's browser-included add-on SDK is different than the one included in Mozilla Firefox, and extension code targeted at one version will likely not be compatible with the other.

For the time being, Pale Moon's add-on SDK is almost fully equivalent to v1.14 of the Mozilla add-on SDK, and this will be kept static for at least the near future. If the SDK develops further, it will not be by adopting a later version of the Firefox add-on SDK, since that SDK is focused specifically on Australis and its different APIs, and is neither future-proof nor backwards compatible. Instead, the included add-on SDK will be documented on the Pale Moon developer/add-on site.

TPS commented 8 years ago

I also just tried v2.5.1 that just popped up - no joy.

TPS commented 8 years ago

Ditto with v2.6.1. :cry: