search

musically-ut / lovely-forks

💚 🍴 Show notable forks of GitHub repositories under their names.
Mozilla Public License 2.0
603 stars 40 forks source link

Text is no longer aligned #35

Closed fregante closed 7 years ago

fregante commented 7 years ago

Native:

lovely forks:

musically-ut commented 7 years ago

This was an explicit change requested in #30. Personally, both styles look okay to me.

Maybe @yfdyh000 will have some opinions about this?

fregante commented 7 years ago

It just looks misaligned to me. GitHub's own style on repos (which I matched years ago here) doesn't show any particular hierarchy either.

If anything, the base repo's larger style already does appear as hierarchically higher.

yfdyh000 commented 7 years ago

I forgot the "Native" style from GitHub, but it is confusing for me, that like an original message from the repo / page, not extra info from the extension.

An user-option may to ease this issue, but I don't know what the default value should be.

fregante commented 7 years ago

But you know it's from the extension because you installed it. The point is that it should blend in with the hosting site, not be visibly off-place. This brings it to GitHub's default position.

Most of the time the fork isn't even useful unless it's more recent, and at that point it will have a nice red flame to bring it to your attention.

yfdyh000 commented 7 years ago

Uniform style is justified, although I prefer to have an indentation to indicate its hierarchy.

Another reason, the "Native" is child to parent, the extension is reversed, so I prefers it to shows this is a different tree structure. This comes from my intuition and may be the real reason.

marsjaninzmarsa commented 7 years ago

I like #30. If you find cleaner way, ok, but indentation was definitely positive change.

musically-ut commented 7 years ago

Thank you for your inputs!

Alright, I've decided to make it a preference on the plugin. I have that implemented on the master branch and I've chosen to stick to the default of not-indenting (after a discussion with @wereHamster offline).

I'll test out the plugin a bit more on a separate computer and then upload the new version to Chrome WebStore and Firefox Addons. In the meanwhile, you can check out the master branch and test-ride the implementation. Feedback, of course, is very welcome. :)

Thanks again!

musically-ut commented 7 years ago

The extension is live on Firefox Addons and on the WebStore now.