musically-ut / lovely-forks

💚 🍴 Show notable forks of GitHub repositories under their names.
Mozilla Public License 2.0
598 stars 40 forks source link

Lovely Forks menu item #44

Open Grossdm opened 6 years ago

Grossdm commented 6 years ago

On Fennec 60.0, there is a menu item for Lovely Forks regardless of the current website. I tapped it just to see if my phone would explode, but it did nothing.

Surely the menu item can be removed when not in GitHub?

Thanks,

Doug®

musically-ut commented 6 years ago

Thanks for the report; I'm glad that your phone didn't explode. :)

I vaguely remember that page-action was not fully supported in Firefox and, hence, I had to make it into a Menu action. And then Chrome moved to showing the extension icons always and they had to be hidden manually one by one; so I forgot about this discrepancy completely.

I am not sure what the state of the affairs is now, but there is little point in the extension icon appearing on any menu at all. I will try to remove it completely in the next version and will ask you to check and close the issue.

Also, thanks for using Lovely Forks! 😊

Grossdm commented 6 years ago

Thank you for the response!

Fennec is getting a bit "unruly" with its menu and address bar icons. That is, with all the addons that I have installed. :grin:

One example of excess is Dark Background and Light Text, also on GitHub. It places both an icon next to (on?) my address bar and an item in the menu.

The Fennec address bar on my Paleophone (Galaxy Note 3, my first non-Motorola and my last Samsung smartphone. LG? Sony?) is getting full with Fennec's ideas for a "Reader Mode" icon and most annoyingly a button/icon with the sole purpose of dropping a link to the URL on the home screen.

I think it would be nice if addons that need to add a menu item are provided a sub-menu. This would be quicker to access than, well I have to scroll my menu if I have enough addons enabled. I think it would be better than just dumping the addons' items onto the current menu.

Oh, and just in case Mozilla is reading, Please put a small :mag: icon on the "Find in page" menu item!

Happy coding,

Doug®