musically-ut / lovely-forks

💚 🍴 Show notable forks of GitHub repositories under their names.
Mozilla Public License 2.0
603 stars 40 forks source link

Suggestions: make the text grayed out until mouseover + have smaller text size #60

Closed darkred closed 3 years ago

darkred commented 3 years ago

First, thank you for this very useful extension!


I'd like to make two suggestions about the text:

The also forked to text, not being grayed out, becomes distractive compared to the repo name, even though it's additional info: the most notable fork is surely very useful info, but less important that the original repo that the current one was forked from.

 

Here is a screenshot comparison:

forked from (default by GitHub in forks) 2020-11-23_222306

also forked to (this extension) 2020-11-23_222341

musically-ut commented 3 years ago

Indeed, you are right that the CSS formatting of this extension has drifted slightly since the new GitHub rebranding.

I'll fix it this coming weekend.

Thanks!

darkred commented 3 years ago

Thank you for the quick response.

How do you find my suggestion to make the text grayed out until mouseover ?

musically-ut commented 3 years ago

I would prefer to stick to GitHub's own styling as much as possible.

I can see the argument that it is not as important as the repo-name itself, but find the argument from consistency marginally more compelling. 🙃

darkred commented 3 years ago

Offering it as an option, disabled by default?

musically-ut commented 3 years ago

I've changed the styling of the text to match the forked from in the extension. However, I haven't implemented the greying out partly because it is more work, and partly because we may need to change the grey based on light/dark mode. I don't want to throw in more GitHub layout-dependent features into the extension quite yet. :)