search

musically-ut / lovely-forks

💚 🍴 Show notable forks of GitHub repositories under their names.
Mozilla Public License 2.0
603 stars 40 forks source link

Blank panel bug in navbar #62

Closed Christopher-Hayes closed 3 years ago

Christopher-Hayes commented 3 years ago

Hello, there's this blank panel that shows in the navbar, below the notification bell.

In dark mode: image In light mode: image

CSS: element classes: .d-none.d-lg-block.mt-6.mr-3.Popover.top-0.right-0.box-shadow-medium.col-3 image

image

Disabling/enabling the add-on shows that the styling below is being added to this element. image

Disabling the styling above removes the display bug: image

This is the code in question: https://github.com/musically-ut/lovely-forks/blob/6e9f0ee932505dfc2ffa3b9c25557889b253bf96/webext/data/style.css#L1:L4

Seems like this is a regression resulting from this bugfix: https://github.com/musically-ut/lovely-forks/issues/53

musically-ut commented 3 years ago

Wow. Thanks for the detailed analysis!

Indeed, that PR for the new GitHub layout seems to be the culprit here. However, I do not see it myself on my browser. Which browser are you using and are you using the extension or the user-script?

I'll investigate and try to replicate it myself and will ask you more questions.

Christopher-Hayes commented 3 years ago

I'm seeing it on Firefox 84 and Chrome 86, both using the browser addon/extension. Both extensions are running v3.5.0. An important detail I forgot to mention is I only see this when I open the page of a repo and I have the "Code" tab selected.

musically-ut commented 3 years ago

Excellent; I can now reproduce it. Thanks!