search

musically-ut / lovely-forks

💚 🍴 Show notable forks of GitHub repositories under their names.
Mozilla Public License 2.0
603 stars 40 forks source link

Too many lovely forkers with the same username and stars #64

Closed zplusfour closed 3 years ago

zplusfour commented 3 years ago

So I went to microsoft/vscode, and look at this:

image

This is probably a bug, please fix it, thanks!!

musically-ut commented 3 years ago

!

I don't see it on my browser :(

Can you tell me:

  1. which browser
  2. which OS
  3. which extension version

you are using?

Thanks for the report!

zplusfour commented 3 years ago

sure

  1. Chrome
  2. Windows
  3. 3.6.0
musically-ut commented 3 years ago

Do you happen to have any ad-blockers or some such running on the page as well?

The code has a hard check to make sure that it adds only one or zero elements. This can happen only if something is scrubbing the classnames the extension is adding to the tags.

Also, does this happen directly on page load or after navigating to other tabs (Issues/Pull Requests, etc.)? Do you happen to have the console output when this happens too?

The bug has puzzled me.

zplusfour commented 3 years ago

Oh, I went to vscode again and I don't see it now :)

zplusfour commented 3 years ago
  1. no I don't have any ad blocker, and github has no ads
  2. um I went to microsoft to see their projects, I saw vscode and I clicked on it, that's it
  3. I am sorry :(
musically-ut commented 3 years ago

Classic Heisenbug! :D

I'll close this issue for now; let's pick it up again if it happens again. :)

Thanks for reporting it; I hope you report when it happens again; it may be a race condition somewhere in the code.

zplusfour commented 3 years ago

:D

yeah probably

zplusfour commented 3 years ago

oh no here we go again

image

zplusfour commented 3 years ago

Im verry sorry

musically-ut commented 3 years ago

:D

No need to be sorry; now I just have to figure out how this is possible. I stay on GitHub all the time; I'll keep an eye out for this myself.

How frequently does it seem to happen?

zplusfour commented 3 years ago

Ok, good Wait I have an idea I am a JavaScript/TypeScript expert, I'll fork it and try to fix this, and if I fixed it, I'll make a pr

musically-ut commented 3 years ago

That would be awesome!

zplusfour commented 3 years ago

yeah!

hauk92 commented 3 years ago

You can reproduce this by going to an issue page and then returning to the previous page. For example go to https://github.com/microsoft/vscode/issues and wait for lovely forks to load, then go back to the issues page by clicking your "back" button in the browser - now two forks of the same name and author are shown. You can repeat this by going forward and back again and another fork will appear.

musically-ut commented 3 years ago

Aah, the key step was to hit the back button instead of just swapping between Issues and Code tabs.

Now that I can reproduce it, I can work on it. :)

Thanks @hauk92 !

musically-ut commented 3 years ago

Thanks to @Jorgen1040, this should be fixed in version 3.6.1 of the extension. I've uploaded it both to Firefox and Chrome, coming to a webstore near you soon!