search

musicbeeremote / mbrc-plugin

MusicBee Remote Plugin
http://mbrc.kelsos.net
Other
114 stars 13 forks source link

Maximum library size of 4,000 #101

Closed interpolalchemi closed 12 months ago

interpolalchemi commented 12 months ago

I can see from your source that you have limited the library size to 4,000 - I understand that there is a limit posed by network speeds, but I use this (great!) remote on a local network and it would be nice if it were a setting or something.

Thank you :)

kelsos commented 12 months ago

I can see from your source that you have limited the library size to 4,000 - I understand that there is a limit posed by network speeds, but I use this (great!) remote on a local network and it would be nice if it were a setting or something.

Thank you :)

Hey @interpolalchemi that's the default value mostly for legacy reasons.

The API both in master and the v1 branch supports pagination via offset and limit so you can specify these values.

https://github.com/musicbeeremote/mbrc-plugin/blob/2f301a32efc10782a9a25f200906fd8e7c473e17/plugin/AndroidRemote/Commands/Requests/RequestBrowseArtists.cs#L14

The application is doing 800 items per page when syncing. This was found optimal for memory usage and parsing speed when I was testing stuff. But the sync mechanism should pull all the available tracks page by page.

https://github.com/musicbeeremote/mbrc/blob/e74e93432f5bb3641ebc850fbb700db52978b375/app/src/main/kotlin/com/kelsos/mbrc/repository/data/RemoteDataSource.kt#L12

In general, if you are using the v1 of the plugin and v1.5.1 of the app you should not be limited to 4000 items in the library.

interpolalchemi commented 12 months ago

🤦‍♂️ Duh

Thanks for pointing out what I was missing