musicbeeremote / mbrc-plugin

MusicBee Remote Plugin
http://mbrc.kelsos.net
Other
114 stars 13 forks source link

Issue with rating system #27

Closed 0x00000001 closed 7 years ago

0x00000001 commented 7 years ago

I have a issue with the rating system: full star ratings (1 Star up to 5 stars) works fine, but half star rating (half star, 1 1/2 star up to 4 1/2 star) ratings results in wrong ratings in music bee:

0.5 star (in app) -> 5.0 stars (in music bee) 1.5 star -> 1.0 star 2.5 star -> 1.5 star 3.5 star -> 2.0 star 4.5 star -> 2.5 star

It seems the problem comes from the plugin: App (version 0.11.2) works without problems with plugin in version 0.13.0 but with plugin in version 1.0.0 the problem arises. App in version 1.0.1 have also this problem with plugin in version 1.0.0.

kelsos commented 7 years ago

Thank you for reporting I will take a look, I had some issues at some point related with the ./, used as a separator for decimal digits it could be related to this.

kelsos commented 7 years ago

@0x00000001 any chance that you could provide information on the locale settings of both the PC that runs MusicBee and the Android device running the application?

I use on both devices a English US locale so the problem and it seems to work fine. I am almost certain that this is caused by the locale settings.

kelsos commented 7 years ago

Fixed on a665c3d The issue was with the floating point conversion. It should be in the next update.

0x00000001 commented 7 years ago

Many thanks for fixing the problem :), and sorry I did'nt see your question :(. For the record: I use on both devices German localisation.

kelsos commented 7 years ago

No worries. It was due to the localization indeed. I was passing to MusicBee x.5 while it was expecting x,5. Hopefully there will be an update in the following week.

kelsos commented 7 years ago

@0x00000001 I published a plugin release v1.1.0, could you verify that it works for you?

0x00000001 commented 7 years ago

It works :) I tested it with App release 0.11.2 and the actual 1.0.1 and the problem is solvend.

Many thanks :) 👍