musicpd / mpd-overlay

Live Ebuilds for MusicPD related applications
4 stars 1 forks source link

media-sound/mpd-9999::mpd fails building with libcdio-paranoia installed #3

Open ghost opened 10 years ago

ghost commented 10 years ago

As you guys know I no longer use Gentoo, but this email was forwarded to me the other day.

The following lines from the mpd-9999.ebuild cause src_prepare to fail:

if has_version dev-libs/libcdio-paranoia; then sed -i \ -e 's:cdio/paranoia.h:cdio/paranoia/paranoia.h:' \ src/input/CdioParanoiaInputPlugin.cxx || die fi With the following error message: sed: can't read src/input/CdioParanoiaInputPlugin.cxx: No such file or directory The version of libcdio-paranoia I have installed is 0.90_p1-r1. I have USE="-cdio", though, so mpd shouldn't even be using it in the first place. The correct path should be src/input/plugins/CdioParanoiaInputPlugin.cxx. This file, however, contains an #ifdef choosing between cdio/paranoia.h and cdio/paranoia/paranoia.h, so I'm doubtful as to whether the sed is required at all. I suggest checking whether the sed is still required and fixing the paths if so, removing it if otherwise. Furthermore, I suggest checking for the presence of the cdio USE flag before running such operations in the future, if possible. Thanks ~