musikinformatik / SuperDirt

Tidal Audio Engine
GNU General Public License v2.0
519 stars 75 forks source link

Fixed small pitch shifting bug in SynthDef and add a parameter #206

Closed thgrund closed 3 years ago

thgrund commented 3 years ago

I have seen that there is a "dirt_pitch_shift" module in core_synths. Unfortunately it does not work as intended, because the pitch shift parameter "pitchRatio" in core_synths is called psratio and in core_modules psrate. I fixed this typo (now it is called psrate everywhere) and was able to use it successfully on the tidal side.

I also added the timeDispersion parameter for PitchShift and named it disp.

thgrund commented 3 years ago

Sure, that's no problem. I renamed disp to psdisp. I like these clarification, because that way you can better associate psdisp with psrate.

telephon commented 3 years ago

Thank you!