dirt-synth: move gain and overgain to synth

musikinformatik / SuperDirt

Tidal Audio Engine

GNU General Public License v2.0

519 stars 75 forks source link

dirt-synth: move gain and overgain to synth #220

Closed telephon closed 3 years ago

telephon commented 3 years ago

This will allow a continuous modulation of amp with bus mappings.

It is a bit more expensive, but I have tried to minimise by making gain and overgain unmodulatable.

telephon commented 3 years ago

Note that this might change the behaviour in places where a synth has an explict amp argument and one uses gain on it. This is not currently the case in the synths in superdirt.

yaxu commented 3 years ago

Ah sorry I hadn't actually tested this out properly before release - it seems that gain and overgain aren't now working. amp is fine. I tried with samples and synths (supermandolin and superpiano). even gain 0 has no effect.