search

musikinformatik / SuperDirt

Tidal Audio Engine
GNU General Public License v2.0
524 stars 76 forks source link

delay stops working sometimes #270

Closed ahihi closed 2 years ago

ahihi commented 2 years ago

every now and then after i've been iterating on a pattern for a while, the dirt_delay on that orbit goes silent and stops responding to any arguments from tidal. not sure what exactly triggers it.

this is the first variant of dirt_delay which uses SwitchDelay when sc3-plugins is installed. i noticed that unlike others, this synth runs two pausing ugens (1, 2) with one even having a comment saying it doesn't work properly. i don't understand the effect synth lifecycle well but this seems like it could be problematic.

the last time the bug happened i was able to restart the delay with ~dirt.orbits[3].globalEffects[0].resume, indicating that the synth is indeed staying paused when it shouldn't. i tried commenting out the DetectSilence line and kept tidaling successfully for about an hour with all delays working fine. not exactly solid evidence yet but i'll test more later!

telephon commented 2 years ago

Indeed I suspect that the DetectSilence is an old leftover. Can you continue to test it just to be sure? I'll take a look at it if I can find the time.

ahihi commented 2 years ago

i will, once i have some time during the weekend!

ahihi commented 2 years ago

5-ish more hours of tidaling later, delays are still working great :)

telephon commented 2 years ago

Thanks :)!