search

musiqpad / mqp-server

NodeJS server base for hosting an individual pad
MIT License
30 stars 18 forks source link

Disconnected session can still be cycled into queue #28

Open foodbandlt opened 8 years ago

foodbandlt commented 8 years ago

Disconnected sessions that are on the waitlist or DJing will still be added back to queue if queue cycling is turned on. This should be the case, and they should not be added back to queue after finished DJing.

In addition to that, should disconnected sessions even be allowed to DJ? If a user disconnects in position 2, they will then begin DJing and disconnect mid-song because the 6 minute timer expires. Either don't let them DJ at all if it's their turn while disconnected, or let the song play our in its entirety.

DerpgonCz commented 8 years ago

I'd say let them stay in the queue, and if they are still disconnected by the time it is their turn then skip them.

If they are disconnected by the time they finish playing, do not add them back when cycling is enabled.

Also, should we skip DJs that disconnect while playing?

foodbandlt commented 8 years ago

I think they should be disconnected after their play, not during. If they disconnect while playing, wait for their song to be over (or for them to be skipped), then do not cycle them back into queue and then finish disconnecting them.

DerpgonCz commented 8 years ago

I'd say aswell, fair enough