search

musiqpad / mqp-server

NodeJS server base for hosting an individual pad
MIT License
30 stars 18 forks source link

Grabbed tracks should add to the bottom of playlists #41

Closed ImGrumpy closed 8 years ago

ImGrumpy commented 8 years ago

When adding a song from search results to a playlist, it is appropriate for songs to be added to the top of that playlist. However when grabbing a currently playing track, those should be added to the bottom of the playlist since they've obviously just been played.

foodbandlt commented 8 years ago

I believe it already does that: http://i.imgur.com/ulbwNxK.png

DerpgonCz commented 8 years ago

As @foodbandlt said, I think it is already implemented - and I have the feeling I was implementing it :eyes:

ImGrumpy commented 8 years ago

Ok, I figured this out - it DOES add to the bottom as you show if you add it to the active playlist. If you add it to a specific playlist, it adds it to the top instead.

foodbandlt commented 8 years ago

Ahh, yeah. I remember that. I blame @DerpgonCz <3

TheBanHammer commented 8 years ago

Closing issue as expected functionality is working. Not a Bug

ImGrumpy commented 8 years ago

I really wish you guys would reconsider this. I can't understand the logic of adding a grabbed track to the top of any playlist since it's been recently played. And since it adds to the bottom of the playlist that's active or to the top of other playlists, it's confusingly inconsistent.

foodbandlt commented 8 years ago

Eh, I don't see why not. I think you're right, it would make it more consistent rather than adding confusing conditions where sometimes something happens and not other times.

TheBanHammer commented 8 years ago

Fixed in 781dfaf

ImGrumpy commented 8 years ago

Ok, I hate to keep adding to this, especially if this new behavior is because I asked for it... but I was expecting that grabbed tracks (regardless of their target playlist) would go to the bottom while searched for tracks would add to the top like they did previously. It looks like searched for additions are also going to the bottom now?

ImGrumpy commented 8 years ago

These fixes were somehow lost and the behavior reverted to songs always being added to the top of the playlist. Expected behavior, add to the top for searched songs, add to the bottom for grabbed songs.