musiqpad / mqp-server

NodeJS server base for hosting an individual pad
MIT License
30 stars 18 forks source link

Ask for notification permission after toggled, not on event #63

Closed tnws closed 8 years ago

tnws commented 8 years ago

The current way that mqp works is this: after you toggle one of the desktop notifications on musiqpad, it then asks you for permission to send a notification after the event in question has been fired. An alternative to this would be, on toggle of a setting, first checking if that permission is already granted, if not, prompt the user for permission.

It doesn't seem the best to ask after the event has been fired, which is what seems to be the case.