search

musiqpad / mqp-server

NodeJS server base for hosting an individual pad
MIT License
30 stars 18 forks source link

[Feature] Extra characters in name #88

Closed RwbyChan2 closed 8 years ago

RwbyChan2 commented 8 years ago

Maybe allowing users to have more characters to use in their username? Such as a space for example?

TheBanHammer commented 8 years ago

In my opinion I don't think this should be a thing. It would make things like mentions much harder.

ImGrumpy commented 8 years ago

Extra characters maybe, but definitely not spaces. Agree with TBH 100%. Spaces also makes it very hard for a bot to parse out commands aimed at a particular user.

DerpgonCz commented 8 years ago

More characters as in character count - no problem with that, but having a long usernames makes it

a) Harder to remember b) Makes it too fancy (and standing out among the others) c) There would be problems with some names being too long and thus filling up most of the row - which does not look great at all

You can change checking username validity (and thus removing any limits) in https://github.com/musiqpad/mqp-server/blob/master/socketserver/database_util.js#L13 but, of course, on your own responsibility

That being said, we will most likely be keeping the 20 alphanum with _ and - characters limit

RwbyChan2 commented 8 years ago

Okey