musonza / chat

A Laravel chat package. You can use this package to create a chat/messaging Laravel application.

MIT License

1.12k stars 308 forks source link

fix: postgres exception occurred while fetching the conversation list. #327

Open the0day opened 3 months ago

the0day commented 3 months ago

This pull request fixes an SQL error while fetching the conversation list via: Chat::conversations()->setParticipant($user)->get();

ERROR: SELECT DISTINCT ON expressions must match initial ORDER BY expressions.

Related issues:

269

164

Saifallak commented 3 months ago

Duplicate of #270 ?

the0day commented 3 months ago

Duplicate of #270 ?

I am not sure, but I guess that fix breaks the sorting of conversation list. Before: sorting by last update(last message date) After: sorting by conversation id

My fix keeps the same sorting.